Sign upLogin

fabiocicerchia/go-proxy-cache

View on GitHub
Star
telemetry/metrics/metrics.go

Summary

Maintainability
C
7 hrs
Test Coverage

File metrics.go has 533 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package metrics

import (
    "fmt"
    "net/http"
Severity: Minor
Found in telemetry/metrics/metrics.go - About 2 hrs to fix

    Function IncWholeResponse has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    func IncWholeResponse(reqID string, req http.Request, statusCode int, size int, duration int64, scheme string, cached bool, stale bool) {
    Severity: Major
    Found in telemetry/metrics/metrics.go - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

          } else if code < 600 {
        request5xx.With(labels).Inc()
    }
      Severity: Major
      Found in telemetry/metrics/metrics.go - About 45 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func SetUpstreamServerHealthChecksHealthy(server string, upstream string) {
    hostname, _ := os.Hostname()
    labels := prometheus.Labels{
        "hostname": hostname,
        "env":      os.Getenv("TRACING_ENV"),
        Severity: Minor
        Found in telemetry/metrics/metrics.go and 1 other location - About 35 mins to fix
        telemetry/metrics/metrics.go on lines 613..625

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 104.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func SetUpstreamServerHealthChecksUnhealthy(server string, upstream string) {
    hostname, _ := os.Hostname()
    labels := prometheus.Labels{
        "hostname": hostname,
        "env":      os.Getenv("TRACING_ENV"),
        Severity: Minor
        Found in telemetry/metrics/metrics.go and 1 other location - About 35 mins to fix
        telemetry/metrics/metrics.go on lines 583..595

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 104.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        func IncUpstreamServerResponseTime(server string, upstream string, val float64) {
    hostname, _ := os.Hostname()
    labels := prometheus.Labels{
        "hostname": hostname,
        "env":      os.Getenv("TRACING_ENV"),
        Severity: Minor
        Found in telemetry/metrics/metrics.go and 2 other locations - About 30 mins to fix
        telemetry/metrics/metrics.go on lines 506..516
        telemetry/metrics/metrics.go on lines 519..529

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 101.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        func IncUpstreamServerReceived(server string, upstream string, val float64) {
    hostname, _ := os.Hostname()
    labels := prometheus.Labels{
        "hostname": hostname,
        "env":      os.Getenv("TRACING_ENV"),
        Severity: Minor
        Found in telemetry/metrics/metrics.go and 2 other locations - About 30 mins to fix
        telemetry/metrics/metrics.go on lines 506..516
        telemetry/metrics/metrics.go on lines 532..541

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 101.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        func IncUpstreamServerSent(server string, upstream string, val float64) {
    hostname, _ := os.Hostname()
    labels := prometheus.Labels{
        "hostname": hostname,
        "env":      os.Getenv("TRACING_ENV"),
        Severity: Minor
        Found in telemetry/metrics/metrics.go and 2 other locations - About 30 mins to fix
        telemetry/metrics/metrics.go on lines 519..529
        telemetry/metrics/metrics.go on lines 532..541

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 101.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status