fetzi/phpspec-watcher

View on GitHub

Showing 3 of 3 total issues

Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

        OutputStyle $output,
        FileWatcher $fileWatcher,
        LoopInterface $loop,
        Stdio $stdio,
        int $checkInterval,
Severity: Major
Found in src/Watcher.php - About 1 hr to fix

    Missing class import via use statement (line '28', column '29').
    Open

            $notification = new \Joli\JoliNotif\Notification();
    Severity: Minor
    Found in src/Notification.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    The method runTests uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
                $this->notifyError();
            }
    Severity: Minor
    Found in src/Watcher.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
    {
        public function bar($flag)
        {
            if ($flag) {
                // one branch
            } else {
                // another branch
            }
        }
    }

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Severity
    Category
    Status
    Source
    Language