Sign upLogin

firehoseio/firehose

View on GitHub
Star
lib/firehose/cli.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method publish has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    def publish(uri, payload=nil)
      payload     ||= $stdin.read
      client      = Firehose::Client::Producer::Http.new(uri)
      path        = ::URI.parse(uri).path
      times       = options[:times]
Severity: Minor
Found in lib/firehose/cli.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

TODO found
Open

        # TODO I think this can be cleaned up so the top-level if/else can be ditched.
Severity: Minor
Found in lib/firehose/cli.rb by fixme

Use == if you meant to do a comparison or wrap the expression in parentheses to indicate you meant to assign in a condition.
Open

        if interval = options[:interval]
Severity: Minor
Found in lib/firehose/cli.rb by rubocop

This cop checks for assignments in the conditions of if/while/until.

Example:

# bad

if some_var = true
  do_something
end

Example:

# good

if some_var == true
  do_something
end

There are no issues that match your filters.

Category
Status