Sign upLogin

firehoseio/firehose

View on GitHub
Star
lib/firehose/rack/app.rb

Summary

Maintainability
A
25 mins
Test Coverage
F
48%

Method call has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def call(env)
        # Cache the parsed request so we don't need to re-parse it when we pass
        # control onto another app.
        req     = env['parsed_request'] ||= ::Rack::Request.new(env)
        method  = req.request_method
Severity: Minor
Found in lib/firehose/rack/app.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

TODO found
Open

            # TODO - 'harden' this up with a GET request and throw a "Bad Request"
Severity: Minor
Found in lib/firehose/rack/app.rb by fixme

There are no issues that match your filters.

Category
Status