Sign upLogin

firehoseio/firehose

View on GitHub
Star
lib/firehose/rack/consumer/http_long_poll.rb

Summary

Maintainability
A
2 hrs
Test Coverage
C
71%

Method has too many lines. [35/30]
Open

          def respond_async(channel, last_sequence, params, env)
            EM.next_tick do
              if last_sequence < 0
                async_callback env, 400, "The last_message_sequence parameter may not be less than zero"
              else
Severity: Minor
Found in lib/firehose/rack/consumer/http_long_poll.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method respond_async has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

          def respond_async(channel, last_sequence, params, env)
            EM.next_tick do
              if last_sequence < 0
                async_callback env, 400, "The last_message_sequence parameter may not be less than zero"
              else
Severity: Minor
Found in lib/firehose/rack/consumer/http_long_poll.rb - About 1 hr to fix

    Method respond_async has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

              def respond_async(channel, last_sequence, params, env)
            EM.next_tick do
              if last_sequence < 0
                async_callback env, 400, "The last_message_sequence parameter may not be less than zero"
              else
    Severity: Minor
    Found in lib/firehose/rack/consumer/http_long_poll.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    TODO found
    Open

                        # TODO: Can we send all of these messages down in one request? Sending one message per
    Severity: Minor
    Found in lib/firehose/rack/consumer/http_long_poll.rb by fixme

    Unused method argument - channel. If it's necessary, use _ or _channel as an argument name to indicate that it won't be used.
    Open

              def wrap_frame(channel, message)
    Severity: Minor
    Found in lib/firehose/rack/consumer/http_long_poll.rb by rubocop

    This cop checks for unused method arguments.

    Example:

    # bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

    Example:

    # good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

    Use == if you meant to do a comparison or wrap the expression in parentheses to indicate you meant to assign in a condition.
    Open

                if cb = env["async.callback"]
    Severity: Minor
    Found in lib/firehose/rack/consumer/http_long_poll.rb by rubocop

    This cop checks for assignments in the conditions of if/while/until.

    Example:

    # bad

if some_var = true
  do_something
end

    Example:

    # good

if some_var == true
  do_something
end

    There are no issues that match your filters.

    Category
    Status