firehoseio/firehose

Method call has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

      def call(env)
        req           = env['parsed_request'] ||= ::Rack::Request.new(env)
        path          = req.path
        method        = req.request_method
        cache_control = {}

Use == if you meant to do a comparison or wrap the expression in parentheses to indicate you meant to assign in a condition.

Open

        if deprecated = env["HTTP_X_FIREHOSE_DEPRECATED"]

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

# bad

if some_var = true
  do_something
end

# good

if some_var == true
  do_something
end

Use == if you meant to do a comparison or wrap the expression in parentheses to indicate you meant to assign in a condition.

Open

        if persist = env["HTTP_X_FIREHOSE_PERSIST"]

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

# bad

if some_var = true
  do_something
end

# good

if some_var == true
  do_something
end

Use == if you meant to do a comparison or wrap the expression in parentheses to indicate you meant to assign in a condition.

Open

        if cache_control_header = env['HTTP_CACHE_CONTROL']

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

# bad

if some_var = true
  do_something
end

# good

if some_var == true
  do_something
end

Use == if you meant to do a comparison or wrap the expression in parentheses to indicate you meant to assign in a condition.

Open

        if buffer_size = env["HTTP_X_FIREHOSE_BUFFER_SIZE"]

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

# bad

if some_var = true
  do_something
end

# good

if some_var == true
  do_something
end