Sign upLogin

firehoseio/firehose

View on GitHub
Star
lib/firehose/server/channel_subscription.rb

Summary

Maintainability
A
0 mins
Test Coverage
A
94%

TODO found
Open

        # TODO -ARRRG!!!! We can't listen to deferrables here. Need to expose those
Severity: Minor
Found in lib/firehose/server/channel_subscription.rb by fixme

Use == if you meant to do a comparison or wrap the expression in parentheses to indicate you meant to assign in a condition.
Open

          if mf = Server.configuration.message_filter
Severity: Minor
Found in lib/firehose/server/channel_subscription.rb by rubocop

This cop checks for assignments in the conditions of if/while/until.

Example:

# bad

if some_var = true
  do_something
end

Example:

# good

if some_var == true
  do_something
end

Use == if you meant to do a comparison or wrap the expression in parentheses to indicate you meant to assign in a condition.
Open

          if realIp = env["HTTP_X_FORWARDED_FOR"]
Severity: Minor
Found in lib/firehose/server/channel_subscription.rb by rubocop

This cop checks for assignments in the conditions of if/while/until.

Example:

# bad

if some_var = true
  do_something
end

Example:

# good

if some_var == true
  do_something
end

There are no issues that match your filters.

Category
Status