Sign upLogin

fisharebest/webtrees

View on GitHub
Star
app/Date.php

Summary

Maintainability
D
2 days
Test Coverage

Function display has a Cognitive Complexity of 63 (exceeds 5 allowed). Consider refactoring.
Open

    public function display(Tree|null $tree = null, string|null $date_format = null, bool $convert_calendars = false): string
    {
        if ($tree instanceof Tree) {
            $CALENDAR_FORMAT = $tree->getPreference('CALENDAR_FORMAT');
        } else {
Severity: Minor
Found in app/Date.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method display has 108 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function display(Tree|null $tree = null, string|null $date_format = null, bool $convert_calendars = false): string
    {
        if ($tree instanceof Tree) {
            $CALENDAR_FORMAT = $tree->getPreference('CALENDAR_FORMAT');
        } else {
Severity: Major
Found in app/Date.php - About 4 hrs to fix

    Method compare has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function compare(Date $a, Date $b): int
    {
        // Get min/max JD for each date.
        switch ($a->qual1) {
            case 'BEF':
    Severity: Minor
    Found in app/Date.php - About 1 hr to fix

      Function compare has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function compare(Date $a, Date $b): int
    {
        // Get min/max JD for each date.
        switch ($a->qual1) {
            case 'BEF':
      Severity: Minor
      Found in app/Date.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

              return 0;
      Severity: Major
      Found in app/Date.php - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status