fisharebest/webtrees

View on GitHub
app/Date/HijriDate.php

Summary

Maintainability
F
3 days
Test Coverage

Similar blocks of code found in 14 locations. Consider refactoring.
Open

    protected function monthNameNominativeCase(int $month, bool $leap_year): string
    {
        static $translated_month_names;

        if ($translated_month_names === null) {
Severity: Major
Found in app/Date/HijriDate.php and 13 other locations - About 7 hrs to fix
app/Date/AbstractGregorianJulianDate.php on lines 86..109
app/Date/AbstractGregorianJulianDate.php on lines 121..144
app/Date/AbstractGregorianJulianDate.php on lines 156..179
app/Date/AbstractGregorianJulianDate.php on lines 191..214
app/Date/AbstractGregorianJulianDate.php on lines 224..247
app/Date/HijriDate.php on lines 134..169
app/Date/HijriDate.php on lines 179..214
app/Date/HijriDate.php on lines 224..259
app/Date/JalaliDate.php on lines 86..121
app/Date/JalaliDate.php on lines 131..166
app/Date/JalaliDate.php on lines 176..211
app/Date/JalaliDate.php on lines 221..256
app/Date/JalaliDate.php on lines 266..289

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 229.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 14 locations. Consider refactoring.
Open

    protected function monthNameLocativeCase(int $month, bool $leap_year): string
    {
        static $translated_month_names;

        if ($translated_month_names === null) {
Severity: Major
Found in app/Date/HijriDate.php and 13 other locations - About 7 hrs to fix
app/Date/AbstractGregorianJulianDate.php on lines 86..109
app/Date/AbstractGregorianJulianDate.php on lines 121..144
app/Date/AbstractGregorianJulianDate.php on lines 156..179
app/Date/AbstractGregorianJulianDate.php on lines 191..214
app/Date/AbstractGregorianJulianDate.php on lines 224..247
app/Date/HijriDate.php on lines 89..124
app/Date/HijriDate.php on lines 134..169
app/Date/HijriDate.php on lines 224..259
app/Date/JalaliDate.php on lines 86..121
app/Date/JalaliDate.php on lines 131..166
app/Date/JalaliDate.php on lines 176..211
app/Date/JalaliDate.php on lines 221..256
app/Date/JalaliDate.php on lines 266..289

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 229.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 14 locations. Consider refactoring.
Open

    protected function monthNameInstrumentalCase(int $month, bool $leap_year): string
    {
        static $translated_month_names;

        if ($translated_month_names === null) {
Severity: Major
Found in app/Date/HijriDate.php and 13 other locations - About 7 hrs to fix
app/Date/AbstractGregorianJulianDate.php on lines 86..109
app/Date/AbstractGregorianJulianDate.php on lines 121..144
app/Date/AbstractGregorianJulianDate.php on lines 156..179
app/Date/AbstractGregorianJulianDate.php on lines 191..214
app/Date/AbstractGregorianJulianDate.php on lines 224..247
app/Date/HijriDate.php on lines 89..124
app/Date/HijriDate.php on lines 134..169
app/Date/HijriDate.php on lines 179..214
app/Date/JalaliDate.php on lines 86..121
app/Date/JalaliDate.php on lines 131..166
app/Date/JalaliDate.php on lines 176..211
app/Date/JalaliDate.php on lines 221..256
app/Date/JalaliDate.php on lines 266..289

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 229.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 14 locations. Consider refactoring.
Open

    protected function monthNameGenitiveCase(int $month, bool $leap_year): string
    {
        static $translated_month_names;

        if ($translated_month_names === null) {
Severity: Major
Found in app/Date/HijriDate.php and 13 other locations - About 7 hrs to fix
app/Date/AbstractGregorianJulianDate.php on lines 86..109
app/Date/AbstractGregorianJulianDate.php on lines 121..144
app/Date/AbstractGregorianJulianDate.php on lines 156..179
app/Date/AbstractGregorianJulianDate.php on lines 191..214
app/Date/AbstractGregorianJulianDate.php on lines 224..247
app/Date/HijriDate.php on lines 89..124
app/Date/HijriDate.php on lines 179..214
app/Date/HijriDate.php on lines 224..259
app/Date/JalaliDate.php on lines 86..121
app/Date/JalaliDate.php on lines 131..166
app/Date/JalaliDate.php on lines 176..211
app/Date/JalaliDate.php on lines 221..256
app/Date/JalaliDate.php on lines 266..289

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 229.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status