fisharebest/webtrees

View on GitHub
app/Factories/CalendarDateFactory.php

Summary

Maintainability
C
7 hrs
Test Coverage

Function make has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    public function make(string $date): AbstractCalendarDate
    {
        // Valid calendar escape specified? - use it
        if (preg_match('/^(@#D(?:GREGORIAN|JULIAN|HEBREW|HIJRI|JALALI|FRENCH R|ROMAN)+@) ?(.*)/', $date, $match)) {
            $cal  = $match[1];
Severity: Minor
Found in app/Factories/CalendarDateFactory.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method make has 66 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function make(string $date): AbstractCalendarDate
    {
        // Valid calendar escape specified? - use it
        if (preg_match('/^(@#D(?:GREGORIAN|JULIAN|HEBREW|HIJRI|JALALI|FRENCH R|ROMAN)+@) ?(.*)/', $date, $match)) {
            $cal  = $match[1];
Severity: Major
Found in app/Factories/CalendarDateFactory.php - About 2 hrs to fix

    Avoid too many return statements within this method.
    Open

                    return new FrenchDate([$y, $m, $d]);
    Severity: Major
    Found in app/Factories/CalendarDateFactory.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return new JalaliDate([$y, $m, $d]);
      Severity: Major
      Found in app/Factories/CalendarDateFactory.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return new RomanDate([$y, $m, $d]);
        Severity: Major
        Found in app/Factories/CalendarDateFactory.php - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status