fisharebest/webtrees

View on GitHub
app/Factories/EncodingFactory.php

Summary

Maintainability
C
1 day
Test Coverage

Method detect has 78 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function detect(string $header): ?EncodingInterface
    {
        $utf_bom = [
            '/^' . UTF8::BYTE_ORDER_MARK . '/'    => UTF8::NAME,
            '/^' . UTF16BE::BYTE_ORDER_MARK . '/' => UTF16BE::NAME,
Severity: Major
Found in app/Factories/EncodingFactory.php - About 3 hrs to fix

    Function detect has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        public function detect(string $header): ?EncodingInterface
        {
            $utf_bom = [
                '/^' . UTF8::BYTE_ORDER_MARK . '/'    => UTF8::NAME,
                '/^' . UTF16BE::BYTE_ORDER_MARK . '/' => UTF16BE::NAME,
    Severity: Minor
    Found in app/Factories/EncodingFactory.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method make has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function make(string $name): EncodingInterface
        {
            switch ($name) {
                case UTF8::NAME:
                    return new UTF8();
    Severity: Minor
    Found in app/Factories/EncodingFactory.php - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

                      return new Windows1251();
      Severity: Major
      Found in app/Factories/EncodingFactory.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return new CP437();
        Severity: Major
        Found in app/Factories/EncodingFactory.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return new Windows1250();
          Severity: Major
          Found in app/Factories/EncodingFactory.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return new Windows1252();
            Severity: Major
            Found in app/Factories/EncodingFactory.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                              return new ISO88591();
              Severity: Major
              Found in app/Factories/EncodingFactory.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return new ASCII();
                Severity: Major
                Found in app/Factories/EncodingFactory.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                          return $this->make(UTF8::NAME);
                  Severity: Major
                  Found in app/Factories/EncodingFactory.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return new CP850();
                    Severity: Major
                    Found in app/Factories/EncodingFactory.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                      return new MacRoman();
                      Severity: Major
                      Found in app/Factories/EncodingFactory.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                        return new ISO88592();
                        Severity: Major
                        Found in app/Factories/EncodingFactory.php - About 30 mins to fix

                          There are no issues that match your filters.

                          Category
                          Status