fisharebest/webtrees

View on GitHub
app/Factories/ImageFactory.php

Summary

Maintainability
C
1 day
Test Coverage

Method mediaFileThumbnailResponse has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function mediaFileThumbnailResponse(
        MediaFile $media_file,
        int $width,
        int $height,
        string $fit,
Severity: Minor
Found in app/Factories/ImageFactory.php - About 1 hr to fix

    Method mediaFileThumbnailResponse has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            MediaFile $media_file,
            int $width,
            int $height,
            string $fit,
            bool $add_watermark
    Severity: Minor
    Found in app/Factories/ImageFactory.php - About 35 mins to fix

      Method thumbnailResponse has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              FilesystemOperator $filesystem,
              string $path,
              int $width,
              int $height,
              string $fit
      Severity: Minor
      Found in app/Factories/ImageFactory.php - About 35 mins to fix

        Avoid too many return statements within this method.
        Open

                    return $this->replacementImageResponse((string) StatusCodeInterface::STATUS_INTERNAL_SERVER_ERROR)
                        ->withHeader('x-thumbnail-exception', get_class($ex) . ': ' . $ex->getMessage());
        Severity: Major
        Found in app/Factories/ImageFactory.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return $this->replacementImageResponse((string) StatusCodeInterface::STATUS_INTERNAL_SERVER_ERROR)
                          ->withHeader('x-image-exception', $ex->getMessage());
          Severity: Major
          Found in app/Factories/ImageFactory.php - About 30 mins to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    try {
                        $image = $this->imageManager()->make($filesystem->readStream($path));
                        $image = $this->autorotateImage($image);
                        $image = $this->resizeImage($image, $width, $height, $fit);
            
            
            Severity: Major
            Found in app/Factories/ImageFactory.php and 1 other location - About 3 hrs to fix
            app/Factories/ImageFactory.php on lines 213..256

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 159.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    try {
                        $mime_type = $filesystem->mimeType($path);
            
                        $key = implode(':', [
                            $media_file->media()->tree()->name(),
            Severity: Major
            Found in app/Factories/ImageFactory.php and 1 other location - About 3 hrs to fix
            app/Factories/ImageFactory.php on lines 126..145

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 159.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status