Sign upLogin

fisharebest/webtrees

View on GitHub
Star
app/Gedcom.php

Summary

Maintainability
F
6 days
Test Coverage

File Gedcom.php has 1052 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * webtrees: online genealogy
 * Copyright (C) 2023 webtrees development team
Severity: Major
Found in app/Gedcom.php - About 2 days to fix

    Method gedcom551Tags has 489 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function gedcom551Tags(): array
    {
        return [
            'FAM'                        => new FamilyRecord(I18N::translate('Family')),
            'FAM:*:ADDR'                 => new AddressLine(I18N::translate('Address')),
    Severity: Major
    Found in app/Gedcom.php - About 2 days to fix

      Method customSubTags has 83 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function customSubTags(): array
    {
        $custom_family_tags     = array_filter(explode(',', Site::getPreference('CUSTOM_FAMILY_TAGS')));
        $custom_individual_tags = array_filter(explode(',', Site::getPreference('CUSTOM_INDIVIDUAL_TAGS')));
      Severity: Major
      Found in app/Gedcom.php - About 3 hrs to fix

        Method webtreesSubTags has 64 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function webtreesSubTags(): array
    {
        return [
            'FAM'              => [['_UID', '0:M']],
            'FAM:*:SOUR:DATA'  => [['TEXT', '0:1']],
        Severity: Major
        Found in app/Gedcom.php - About 2 hrs to fix

          Method webtreesTags has 42 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function webtreesTags(): array
    {
        return [
            'FAM:CHAN:_WT_USER'           => new WebtreesUser(I18N::translate('Author of last change')),
            'FAM:*:_ASSO'                 => new XrefAssociate(I18N::translate('Associate')),
          Severity: Minor
          Found in app/Gedcom.php - About 1 hr to fix

            Method registerTags has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function registerTags(ElementFactoryInterface $element_factory, bool $include_custom_tags): void
    {
        // Standard GEDCOM.
        $element_factory->registerTags($this->gedcom551Tags());
            Severity: Minor
            Found in app/Gedcom.php - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          $subtags['FAM:NCHI'] = [
                ['TYPE', '0:1:?'],
                ['DATE', '0:1'],
                ['PLAC', '0:1:?'],
                ['ADDR', '0:1:?'],
              Severity: Major
              Found in app/Gedcom.php and 1 other location - About 3 hrs to fix
              app/Soundex.php on lines 49..66

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 152.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status