Sign upLogin

fisharebest/webtrees

View on GitHub
Star
app/Http/RequestHandlers/GedcomLoad.php

Summary

Maintainability
C
1 day
Test Coverage

Method handle has 121 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function handle(ServerRequestInterface $request): ResponseInterface
    {
        $this->layout = 'layouts/ajax';

        $tree = Validator::attributes($request)->tree();
Severity: Major
Found in app/Http/RequestHandlers/GedcomLoad.php - About 4 hrs to fix

    Function handle has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
    Open

        public function handle(ServerRequestInterface $request): ResponseInterface
    {
        $this->layout = 'layouts/ajax';

        $tree = Validator::attributes($request)->tree();
    Severity: Minor
    Found in app/Http/RequestHandlers/GedcomLoad.php - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                    return $this->viewResponse('admin/import-progress', [
                    'errors'   => '',
                    'progress' => $progress,
                    'status'   => e($ex->getMessage()),
                    'tree'     => $tree,
    Severity: Major
    Found in app/Http/RequestHandlers/GedcomLoad.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return $this->viewResponse('admin/import-progress', [
                'errors'   => $errors,
                'progress' => $progress,
                'status'   => '',
                'tree'     => $tree,
      Severity: Major
      Found in app/Http/RequestHandlers/GedcomLoad.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return $this->viewResponse('admin/import-fail', [
                'error' => e($ex->getMessage()),
                'tree'  => $tree,
            ]);
        Severity: Major
        Found in app/Http/RequestHandlers/GedcomLoad.php - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status