fisharebest/webtrees

View on GitHub
app/Http/RequestHandlers/IndividualPage.php

Summary

Maintainability
B
6 hrs
Test Coverage

Method handle has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function handle(ServerRequestInterface $request): ResponseInterface
    {
        $tree       = Validator::attributes($request)->tree();
        $xref       = Validator::attributes($request)->isXref()->string('xref');
        $slug       = Validator::attributes($request)->string('slug', '');
Severity: Minor
Found in app/Http/RequestHandlers/IndividualPage.php - About 1 hr to fix

    Method metaDescription has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function metaDescription(Individual $individual): string
        {
            $meta_facts = [];
    
            $birth_date  = $individual->getBirthDate();
    Severity: Minor
    Found in app/Http/RequestHandlers/IndividualPage.php - About 1 hr to fix

      Function handle has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function handle(ServerRequestInterface $request): ResponseInterface
          {
              $tree       = Validator::attributes($request)->tree();
              $xref       = Validator::attributes($request)->isXref()->string('xref');
              $slug       = Validator::attributes($request)->string('slug', '');
      Severity: Minor
      Found in app/Http/RequestHandlers/IndividualPage.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function metaDescription has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          private function metaDescription(Individual $individual): string
          {
              $meta_facts = [];
      
              $birth_date  = $individual->getBirthDate();
      Severity: Minor
      Found in app/Http/RequestHandlers/IndividualPage.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

              return I18N::translate('(age %s)', $age);
      Severity: Major
      Found in app/Http/RequestHandlers/IndividualPage.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return '';
        Severity: Major
        Found in app/Http/RequestHandlers/IndividualPage.php - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status