fisharebest/webtrees

View on GitHub
app/Http/RequestHandlers/RenumberTreeAction.php

Summary

Maintainability
F
1 wk
Test Coverage

Method handle has 437 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function handle(ServerRequestInterface $request): ResponseInterface
    {
        $tree  = Validator::attributes($request)->tree();
        $xrefs = $this->admin_service->duplicateXrefs($tree);

Severity: Major
Found in app/Http/RequestHandlers/RenumberTreeAction.php - About 2 days to fix

    File RenumberTreeAction.php has 474 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    /**
     * webtrees: online genealogy
     * Copyright (C) 2023 webtrees development team
    Severity: Minor
    Found in app/Http/RequestHandlers/RenumberTreeAction.php - About 7 hrs to fix

      Function handle has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          public function handle(ServerRequestInterface $request): ResponseInterface
          {
              $tree  = Validator::attributes($request)->tree();
              $xrefs = $this->admin_service->duplicateXrefs($tree);
      
      
      Severity: Minor
      Found in app/Http/RequestHandlers/RenumberTreeAction.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                          foreach (['CHIL', 'ASSO', '_ASSO'] as $tag) {
                              DB::table('families')
                                  ->join('link', static function (JoinClause $join): void {
                                      $join
                                          ->on('l_file', '=', 'f_file')
      Severity: Major
      Found in app/Http/RequestHandlers/RenumberTreeAction.php and 1 other location - About 2 hrs to fix
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 119..132

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 141.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                          foreach (['ALIA', 'ASSO', '_ASSO'] as $tag) {
                              DB::table('individuals')
                                  ->join('link', static function (JoinClause $join): void {
                                      $join
                                          ->on('l_file', '=', 'i_file')
      Severity: Major
      Found in app/Http/RequestHandlers/RenumberTreeAction.php and 1 other location - About 2 hrs to fix
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 103..116

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 141.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 14 locations. Consider refactoring.
      Open

                          DB::table('other')
                              ->join('link', static function (JoinClause $join): void {
                                  $join
                                      ->on('l_file', '=', 'o_file')
                                      ->on('l_from', '=', 'o_id');
      Severity: Major
      Found in app/Http/RequestHandlers/RenumberTreeAction.php and 13 other locations - About 2 hrs to fix
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 206..217
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 219..230
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 232..243
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 269..280
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 293..304
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 306..317
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 319..330
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 332..343
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 345..356
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 375..386
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 388..399
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 401..412
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 414..425

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 121.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 14 locations. Consider refactoring.
      Open

                          DB::table('other')
                              ->join('link', static function (JoinClause $join): void {
                                  $join
                                      ->on('l_file', '=', 'o_file')
                                      ->on('l_from', '=', 'o_id');
      Severity: Major
      Found in app/Http/RequestHandlers/RenumberTreeAction.php and 13 other locations - About 2 hrs to fix
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 206..217
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 219..230
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 232..243
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 245..256
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 269..280
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 293..304
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 306..317
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 319..330
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 332..343
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 375..386
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 388..399
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 401..412
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 414..425

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 121.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 14 locations. Consider refactoring.
      Open

                          DB::table('families')
                              ->join('link', static function (JoinClause $join): void {
                                  $join
                                      ->on('l_file', '=', 'f_file')
                                      ->on('l_from', '=', 'f_id');
      Severity: Major
      Found in app/Http/RequestHandlers/RenumberTreeAction.php and 13 other locations - About 2 hrs to fix
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 206..217
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 232..243
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 245..256
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 269..280
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 293..304
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 306..317
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 319..330
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 332..343
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 345..356
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 375..386
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 388..399
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 401..412
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 414..425

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 121.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 14 locations. Consider refactoring.
      Open

                          DB::table('families')
                              ->join('link', static function (JoinClause $join): void {
                                  $join
                                      ->on('l_file', '=', 'f_file')
                                      ->on('l_from', '=', 'f_id');
      Severity: Major
      Found in app/Http/RequestHandlers/RenumberTreeAction.php and 13 other locations - About 2 hrs to fix
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 206..217
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 219..230
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 232..243
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 245..256
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 269..280
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 293..304
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 306..317
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 319..330
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 332..343
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 345..356
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 375..386
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 401..412
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 414..425

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 121.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 14 locations. Consider refactoring.
      Open

                          DB::table('individuals')
                              ->join('link', static function (JoinClause $join): void {
                                  $join
                                      ->on('l_file', '=', 'i_file')
                                      ->on('l_from', '=', 'i_id');
      Severity: Major
      Found in app/Http/RequestHandlers/RenumberTreeAction.php and 13 other locations - About 2 hrs to fix
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 206..217
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 219..230
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 232..243
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 245..256
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 269..280
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 306..317
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 319..330
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 332..343
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 345..356
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 375..386
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 388..399
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 401..412
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 414..425

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 121.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 14 locations. Consider refactoring.
      Open

                          DB::table('families')
                              ->join('link', static function (JoinClause $join): void {
                                  $join
                                      ->on('l_file', '=', 'f_file')
                                      ->on('l_from', '=', 'f_id');
      Severity: Major
      Found in app/Http/RequestHandlers/RenumberTreeAction.php and 13 other locations - About 2 hrs to fix
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 206..217
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 219..230
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 232..243
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 245..256
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 269..280
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 293..304
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 319..330
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 332..343
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 345..356
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 375..386
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 388..399
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 401..412
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 414..425

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 121.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 14 locations. Consider refactoring.
      Open

                          DB::table('sources')
                              ->join('link', static function (JoinClause $join): void {
                                  $join
                                      ->on('l_file', '=', 's_file')
                                      ->on('l_from', '=', 's_id');
      Severity: Major
      Found in app/Http/RequestHandlers/RenumberTreeAction.php and 13 other locations - About 2 hrs to fix
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 206..217
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 219..230
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 232..243
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 245..256
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 269..280
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 293..304
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 306..317
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 319..330
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 332..343
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 345..356
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 375..386
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 388..399
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 414..425

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 121.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 14 locations. Consider refactoring.
      Open

                          DB::table('sources')
                              ->join('link', static function (JoinClause $join): void {
                                  $join
                                      ->on('l_file', '=', 's_file')
                                      ->on('l_from', '=', 's_id');
      Severity: Major
      Found in app/Http/RequestHandlers/RenumberTreeAction.php and 13 other locations - About 2 hrs to fix
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 206..217
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 219..230
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 232..243
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 245..256
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 269..280
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 293..304
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 306..317
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 319..330
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 345..356
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 375..386
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 388..399
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 401..412
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 414..425

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 121.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 14 locations. Consider refactoring.
      Open

                          DB::table('media')
                              ->join('link', static function (JoinClause $join): void {
                                  $join
                                      ->on('l_file', '=', 'm_file')
                                      ->on('l_from', '=', 'm_id');
      Severity: Major
      Found in app/Http/RequestHandlers/RenumberTreeAction.php and 13 other locations - About 2 hrs to fix
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 206..217
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 219..230
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 245..256
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 269..280
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 293..304
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 306..317
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 319..330
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 332..343
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 345..356
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 375..386
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 388..399
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 401..412
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 414..425

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 121.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 14 locations. Consider refactoring.
      Open

                          DB::table('media')
                              ->join('link', static function (JoinClause $join): void {
                                  $join
                                      ->on('l_file', '=', 'm_file')
                                      ->on('l_from', '=', 'm_id');
      Severity: Major
      Found in app/Http/RequestHandlers/RenumberTreeAction.php and 13 other locations - About 2 hrs to fix
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 206..217
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 219..230
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 232..243
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 245..256
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 269..280
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 293..304
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 306..317
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 332..343
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 345..356
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 375..386
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 388..399
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 401..412
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 414..425

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 121.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 14 locations. Consider refactoring.
      Open

                          DB::table('individuals')
                              ->join('link', static function (JoinClause $join): void {
                                  $join
                                      ->on('l_file', '=', 'i_file')
                                      ->on('l_from', '=', 'i_id');
      Severity: Major
      Found in app/Http/RequestHandlers/RenumberTreeAction.php and 13 other locations - About 2 hrs to fix
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 219..230
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 232..243
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 245..256
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 269..280
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 293..304
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 306..317
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 319..330
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 332..343
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 345..356
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 375..386
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 388..399
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 401..412
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 414..425

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 121.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 14 locations. Consider refactoring.
      Open

                          DB::table('other')
                              ->join('link', static function (JoinClause $join): void {
                                  $join
                                      ->on('l_file', '=', 'o_file')
                                      ->on('l_from', '=', 'o_id');
      Severity: Major
      Found in app/Http/RequestHandlers/RenumberTreeAction.php and 13 other locations - About 2 hrs to fix
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 206..217
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 219..230
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 232..243
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 245..256
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 269..280
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 293..304
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 306..317
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 319..330
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 332..343
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 345..356
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 375..386
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 388..399
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 401..412

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 121.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 14 locations. Consider refactoring.
      Open

                          DB::table('sources')
                              ->join('link', static function (JoinClause $join): void {
                                  $join
                                      ->on('l_file', '=', 's_file')
                                      ->on('l_from', '=', 's_id');
      Severity: Major
      Found in app/Http/RequestHandlers/RenumberTreeAction.php and 13 other locations - About 2 hrs to fix
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 206..217
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 219..230
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 232..243
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 245..256
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 293..304
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 306..317
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 319..330
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 332..343
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 345..356
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 375..386
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 388..399
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 401..412
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 414..425

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 121.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 14 locations. Consider refactoring.
      Open

                          DB::table('individuals')
                              ->join('link', static function (JoinClause $join): void {
                                  $join
                                      ->on('l_file', '=', 'i_file')
                                      ->on('l_from', '=', 'i_id');
      Severity: Major
      Found in app/Http/RequestHandlers/RenumberTreeAction.php and 13 other locations - About 2 hrs to fix
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 206..217
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 219..230
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 232..243
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 245..256
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 269..280
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 293..304
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 306..317
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 319..330
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 332..343
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 345..356
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 388..399
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 401..412
      app/Http/RequestHandlers/RenumberTreeAction.php on lines 414..425

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 121.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status