fisharebest/webtrees

View on GitHub
app/Module/BranchesListModule.php

Summary

Maintainability
F
3 days
Test Coverage

Function getDescendantsHtml has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

    private function getDescendantsHtml(Tree $tree, array $individuals, array $ancestors, string $surname, bool $soundex_dm, bool $soundex_std, Individual $individual, Family $parents = null): string
    {
        $module = $this->module_service->findByComponent(ModuleChartInterface::class, $tree, Auth::user())->first(static function (ModuleInterface $module) {
            return $module instanceof RelationshipsChartModule;
        });
Severity: Minor
Found in app/Module/BranchesListModule.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File BranchesListModule.php has 299 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * webtrees: online genealogy
 * Copyright (C) 2022 webtrees development team
Severity: Minor
Found in app/Module/BranchesListModule.php - About 3 hrs to fix

    Method getDescendantsHtml has 70 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function getDescendantsHtml(Tree $tree, array $individuals, array $ancestors, string $surname, bool $soundex_dm, bool $soundex_std, Individual $individual, Family $parents = null): string
        {
            $module = $this->module_service->findByComponent(ModuleChartInterface::class, $tree, Auth::user())->first(static function (ModuleInterface $module) {
                return $module instanceof RelationshipsChartModule;
            });
    Severity: Major
    Found in app/Module/BranchesListModule.php - About 2 hrs to fix

      Method handle has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function handle(ServerRequestInterface $request): ResponseInterface
          {
              $tree = Validator::attributes($request)->tree();
              $user = Validator::attributes($request)->user();
      
      
      Severity: Minor
      Found in app/Module/BranchesListModule.php - About 1 hr to fix

        Method loadIndividuals has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function loadIndividuals(Tree $tree, string $surname, bool $soundex_dm, bool $soundex_std): array
            {
                $individuals = DB::table('individuals')
                    ->join('name', static function (JoinClause $join): void {
                        $join
        Severity: Minor
        Found in app/Module/BranchesListModule.php - About 1 hr to fix

          Function getPatriarchsHtml has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              private function getPatriarchsHtml(Tree $tree, array $individuals, array $ancestors, string $surname, bool $soundex_dm, bool $soundex_std): string
              {
                  $html = '';
                  foreach ($individuals as $individual) {
                      foreach ($individual->childFamilies() as $family) {
          Severity: Minor
          Found in app/Module/BranchesListModule.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function handle has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              public function handle(ServerRequestInterface $request): ResponseInterface
              {
                  $tree = Validator::attributes($request)->tree();
                  $user = Validator::attributes($request)->user();
          
          
          Severity: Minor
          Found in app/Module/BranchesListModule.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method getDescendantsHtml has 8 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              private function getDescendantsHtml(Tree $tree, array $individuals, array $ancestors, string $surname, bool $soundex_dm, bool $soundex_std, Individual $individual, Family $parents = null): string
          Severity: Major
          Found in app/Module/BranchesListModule.php - About 1 hr to fix

            Method getPatriarchsHtml has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                private function getPatriarchsHtml(Tree $tree, array $individuals, array $ancestors, string $surname, bool $soundex_dm, bool $soundex_std): string
            Severity: Minor
            Found in app/Module/BranchesListModule.php - About 45 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                  if (is_int($sosa) && $module instanceof RelationshipsChartModule) {
                                      $sosa_class = 'search_hit';
                                      $sosa_html  = ' <a class="small wt-chart-box-' . strtolower($spouse->sex()) . '" href="' . e($module->chartUrl($spouse, ['xref2' => $ancestors[1]->xref()])) . '" rel="nofollow" title="' . I18N::translate('Relationship') . '">' . I18N::number($sosa) . '</a>' . self::sosaGeneration($sosa);
                                  } else {
                                      $sosa_class = '';
              Severity: Major
              Found in app/Module/BranchesListModule.php and 1 other location - About 3 hrs to fix
              app/Module/BranchesListModule.php on lines 396..402

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 148.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (is_int($sosa) && $module instanceof RelationshipsChartModule) {
                          $sosa_class = 'search_hit';
                          $sosa_html  = ' <a class="small wt-chart-box-' . strtolower($individual->sex()) . '" href="' . e($module->chartUrl($individual, ['xref2' => $ancestors[1]->xref()])) . '" rel="nofollow" title="' . I18N::translate('Relationship') . '">' . I18N::number($sosa) . '</a>' . self::sosaGeneration($sosa);
                      } else {
                          $sosa_class = '';
              Severity: Major
              Found in app/Module/BranchesListModule.php and 1 other location - About 3 hrs to fix
              app/Module/BranchesListModule.php on lines 434..440

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 148.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status