Sign upLogin

fisharebest/webtrees

View on GitHub
Star
app/Module/FrequentlyAskedQuestionsModule.php

Summary

Maintainability
C
1 day
Test Coverage

File FrequentlyAskedQuestionsModule.php has 287 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * webtrees: online genealogy
 * Copyright (C) 2023 webtrees development team
Severity: Minor
Found in app/Module/FrequentlyAskedQuestionsModule.php - About 2 hrs to fix

    Method getAdminAction has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getAdminAction(ServerRequestInterface $request): ResponseInterface
    {
        $this->layout = 'layouts/administration';

        // This module can't run without a tree
    Severity: Minor
    Found in app/Module/FrequentlyAskedQuestionsModule.php - About 1 hr to fix

      Method postAdminEditAction has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function postAdminEditAction(ServerRequestInterface $request): ResponseInterface
    {
        $block_id    = Validator::queryParams($request)->integer('block_id', 0);
        $body        = Validator::parsedBody($request)->string('body');
        $header      = Validator::parsedBody($request)->string('header');
      Severity: Minor
      Found in app/Module/FrequentlyAskedQuestionsModule.php - About 1 hr to fix

        Method getAdminEditAction has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getAdminEditAction(ServerRequestInterface $request): ResponseInterface
    {
        $this->layout = 'layouts/administration';

        $block_id = Validator::queryParams($request)->integer('block_id', 0);
        Severity: Minor
        Found in app/Module/FrequentlyAskedQuestionsModule.php - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  if ($block_order !== null && $swap_block !== null) {
            DB::table('block')
                ->where('block_id', '=', $block_id)
                ->update([
                    'block_order' => $swap_block->block_order,
          Severity: Minor
          Found in app/Module/FrequentlyAskedQuestionsModule.php and 1 other location - About 45 mins to fix
          app/Module/FrequentlyAskedQuestionsModule.php on lines 262..274

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 95.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  if ($block_order !== null && $swap_block !== null) {
            DB::table('block')
                ->where('block_id', '=', $block_id)
                ->update([
                    'block_order' => $swap_block->block_order,
          Severity: Minor
          Found in app/Module/FrequentlyAskedQuestionsModule.php and 1 other location - About 45 mins to fix
          app/Module/FrequentlyAskedQuestionsModule.php on lines 226..238

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 95.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status