fisharebest/webtrees

View on GitHub
app/Module/IndividualListModule.php

Summary

Maintainability
F
1 wk
Test Coverage

Function createResponse has a Cognitive Complexity of 109 (exceeds 5 allowed). Consider refactoring.
Open

    protected function createResponse(Tree $tree, UserInterface $user, array $params, bool $families): ResponseInterface
    {
        ob_start();

        // We show three different lists: initials, surnames and individuals
Severity: Minor
Found in app/Module/IndividualListModule.php - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File IndividualListModule.php has 675 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * webtrees: online genealogy
 * Copyright (C) 2022 webtrees development team
Severity: Major
Found in app/Module/IndividualListModule.php - About 1 day to fix

    Method createResponse has 261 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function createResponse(Tree $tree, UserInterface $user, array $params, bool $families): ResponseInterface
        {
            ob_start();
    
            // We show three different lists: initials, surnames and individuals
    Severity: Major
    Found in app/Module/IndividualListModule.php - About 1 day to fix

      IndividualListModule has 26 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class IndividualListModule extends AbstractModule implements ModuleListInterface, RequestHandlerInterface
      {
          use ModuleListTrait;
      
          protected const ROUTE_URL = '/tree/{tree}/individual-list';
      Severity: Minor
      Found in app/Module/IndividualListModule.php - About 3 hrs to fix

        Method individuals has 46 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function individuals(
                Tree $tree,
                string $surn,
                string $salpha,
                string $galpha,
        Severity: Minor
        Found in app/Module/IndividualListModule.php - About 1 hr to fix

          Function individuals has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function individuals(
                  Tree $tree,
                  string $surn,
                  string $salpha,
                  string $galpha,
          Severity: Minor
          Found in app/Module/IndividualListModule.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method givenAlpha has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function givenAlpha(Tree $tree, string $surn, string $salpha, bool $marnm, bool $fams, LocaleInterface $locale): array
              {
                  $collation = $this->localization_service->collation($locale);
          
                  $alphas = [];
          Severity: Minor
          Found in app/Module/IndividualListModule.php - About 1 hr to fix

            Method whereInitialHungarian has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function whereInitialHungarian(Builder $query, Expression $field, string $letter): void
                {
                    switch ($letter) {
                        case 'C':
                            $query->where($field, 'LIKE', 'C%')->where($field, 'NOT LIKE', 'CS%');
            Severity: Minor
            Found in app/Module/IndividualListModule.php - About 1 hr to fix

              Function whereInitialHungarian has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function whereInitialHungarian(Builder $query, Expression $field, string $letter): void
                  {
                      switch ($letter) {
                          case 'C':
                              $query->where($field, 'LIKE', 'C%')->where($field, 'NOT LIKE', 'CS%');
              Severity: Minor
              Found in app/Module/IndividualListModule.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method surnameAlpha has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function surnameAlpha(Tree $tree, bool $marnm, bool $fams, LocaleInterface $locale): array
                  {
                      $collation = $this->localization_service->collation($locale);
              
                      $n_surn = $this->fieldWithCollation('n_surn', $collation);
              Severity: Minor
              Found in app/Module/IndividualListModule.php - About 1 hr to fix

                Method surnames has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    protected function surnames(
                        Tree $tree,
                        string $surn,
                        string $salpha,
                        bool $marnm,
                Severity: Minor
                Found in app/Module/IndividualListModule.php - About 1 hr to fix

                  Function givenAlpha has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function givenAlpha(Tree $tree, string $surn, string $salpha, bool $marnm, bool $fams, LocaleInterface $locale): array
                      {
                          $collation = $this->localization_service->collation($locale);
                  
                          $alphas = [];
                  Severity: Minor
                  Found in app/Module/IndividualListModule.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method individuals has 7 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          Tree $tree,
                          string $surn,
                          string $salpha,
                          string $galpha,
                          bool $marnm,
                  Severity: Major
                  Found in app/Module/IndividualListModule.php - About 50 mins to fix

                    Method families has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        protected function families(Tree $tree, string $surn, string $salpha, string $galpha, bool $marnm, LocaleInterface $locale): Collection
                    Severity: Minor
                    Found in app/Module/IndividualListModule.php - About 45 mins to fix

                      Function surnameAlpha has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function surnameAlpha(Tree $tree, bool $marnm, bool $fams, LocaleInterface $locale): array
                          {
                              $collation = $this->localization_service->collation($locale);
                      
                              $n_surn = $this->fieldWithCollation('n_surn', $collation);
                      Severity: Minor
                      Found in app/Module/IndividualListModule.php - About 45 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method givenAlpha has 6 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          public function givenAlpha(Tree $tree, string $surn, string $salpha, bool $marnm, bool $fams, LocaleInterface $locale): array
                      Severity: Minor
                      Found in app/Module/IndividualListModule.php - About 45 mins to fix

                        Method surnames has 6 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                                Tree $tree,
                                string $surn,
                                string $salpha,
                                bool $marnm,
                                bool $fams,
                        Severity: Minor
                        Found in app/Module/IndividualListModule.php - About 45 mins to fix

                          Function whereInitial has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              protected function whereInitial(
                                  Builder $query,
                                  string $field,
                                  string $letter,
                                  LocaleInterface $locale
                          Severity: Minor
                          Found in app/Module/IndividualListModule.php - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function surnames has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              protected function surnames(
                                  Tree $tree,
                                  string $surn,
                                  string $salpha,
                                  bool $marnm,
                          Severity: Minor
                          Found in app/Module/IndividualListModule.php - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                              public function handle(ServerRequestInterface $request): ResponseInterface
                              {
                                  $tree = Validator::attributes($request)->tree();
                                  $user = Validator::attributes($request)->user();
                          
                          
                          Severity: Minor
                          Found in app/Module/IndividualListModule.php and 1 other location - About 40 mins to fix
                          app/Module/FamilyListModule.php on lines 72..80

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 94.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status