fisharebest/webtrees

View on GitHub
app/Module/ModuleDataFixTrait.php

Summary

Maintainability
C
1 day
Test Coverage

Method recordsToFix has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function recordsToFix(Tree $tree, array $params): Collection
    {
        $families     = $this->familiesToFix($tree, $params);
        $individuals  = $this->individualsToFix($tree, $params);
        $locations    = $this->locationsToFix($tree, $params);
Severity: Minor
Found in app/Module/ModuleDataFixTrait.php - About 1 hr to fix

    Function recordsToFix has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function recordsToFix(Tree $tree, array $params): Collection
        {
            $families     = $this->familiesToFix($tree, $params);
            $individuals  = $this->individualsToFix($tree, $params);
            $locations    = $this->locationsToFix($tree, $params);
    Severity: Minor
    Found in app/Module/ModuleDataFixTrait.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        protected function repositoriesToFixQuery(Tree $tree, array $params): Builder
        {
            $query = DB::table('other')
                ->where('o_type', '=', Repository::RECORD_TYPE)
                ->where('o_file', '=', $tree->id());
    Severity: Major
    Found in app/Module/ModuleDataFixTrait.php and 3 other locations - About 1 hr to fix
    app/Module/ModuleDataFixTrait.php on lines 233..244
    app/Module/ModuleDataFixTrait.php on lines 296..307
    app/Module/ModuleDataFixTrait.php on lines 391..402

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 108.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        protected function locationsToFixQuery(Tree $tree, array $params): Builder
        {
            $query = DB::table('other')
                ->where('o_type', '=', Location::RECORD_TYPE)
                ->where('o_file', '=', $tree->id());
    Severity: Major
    Found in app/Module/ModuleDataFixTrait.php and 3 other locations - About 1 hr to fix
    app/Module/ModuleDataFixTrait.php on lines 296..307
    app/Module/ModuleDataFixTrait.php on lines 328..339
    app/Module/ModuleDataFixTrait.php on lines 391..402

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 108.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        protected function submittersToFixQuery(Tree $tree, array $params): Builder
        {
            $query = DB::table('other')
                ->where('o_type', '=', Submitter::RECORD_TYPE)
                ->where('o_file', '=', $tree->id());
    Severity: Major
    Found in app/Module/ModuleDataFixTrait.php and 3 other locations - About 1 hr to fix
    app/Module/ModuleDataFixTrait.php on lines 233..244
    app/Module/ModuleDataFixTrait.php on lines 296..307
    app/Module/ModuleDataFixTrait.php on lines 328..339

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 108.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        protected function notesToFixQuery(Tree $tree, array $params): Builder
        {
            $query = DB::table('other')
                ->where('o_type', '=', Note::RECORD_TYPE)
                ->where('o_file', '=', $tree->id());
    Severity: Major
    Found in app/Module/ModuleDataFixTrait.php and 3 other locations - About 1 hr to fix
    app/Module/ModuleDataFixTrait.php on lines 233..244
    app/Module/ModuleDataFixTrait.php on lines 328..339
    app/Module/ModuleDataFixTrait.php on lines 391..402

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 108.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        protected function mediaToFixQuery(Tree $tree, array $params): Builder
        {
            $query = DB::table('media')
                ->where('m_file', '=', $tree->id());
    
    
    Severity: Major
    Found in app/Module/ModuleDataFixTrait.php and 3 other locations - About 40 mins to fix
    app/Module/ModuleDataFixTrait.php on lines 171..181
    app/Module/ModuleDataFixTrait.php on lines 202..212
    app/Module/ModuleDataFixTrait.php on lines 360..370

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 93.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        protected function sourcesToFixQuery(Tree $tree, array $params): Builder
        {
            $query = DB::table('sources')
                ->where('s_file', '=', $tree->id());
    
    
    Severity: Major
    Found in app/Module/ModuleDataFixTrait.php and 3 other locations - About 40 mins to fix
    app/Module/ModuleDataFixTrait.php on lines 171..181
    app/Module/ModuleDataFixTrait.php on lines 202..212
    app/Module/ModuleDataFixTrait.php on lines 265..275

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 93.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        protected function familiesToFixQuery(Tree $tree, array $params): Builder
        {
            $query = DB::table('families')
                ->where('f_file', '=', $tree->id());
    
    
    Severity: Major
    Found in app/Module/ModuleDataFixTrait.php and 3 other locations - About 40 mins to fix
    app/Module/ModuleDataFixTrait.php on lines 202..212
    app/Module/ModuleDataFixTrait.php on lines 265..275
    app/Module/ModuleDataFixTrait.php on lines 360..370

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 93.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        protected function individualsToFixQuery(Tree $tree, array $params): Builder
        {
            $query = DB::table('individuals')
                ->where('i_file', '=', $tree->id());
    
    
    Severity: Major
    Found in app/Module/ModuleDataFixTrait.php and 3 other locations - About 40 mins to fix
    app/Module/ModuleDataFixTrait.php on lines 171..181
    app/Module/ModuleDataFixTrait.php on lines 265..275
    app/Module/ModuleDataFixTrait.php on lines 360..370

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 93.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status