Sign upLogin

fisharebest/webtrees

View on GitHub
Star
app/Module/PlaceHierarchyListModule.php

Summary

Maintainability
C
1 day
Test Coverage

File PlaceHierarchyListModule.php has 289 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * webtrees: online genealogy
 * Copyright (C) 2023 webtrees development team
Severity: Minor
Found in app/Module/PlaceHierarchyListModule.php - About 2 hrs to fix

    Method mapData has 61 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function mapData(Place $place): array
    {
        $children  = $place->getChildPlaces();
        $features  = [];
        $sidebar   = '';
    Severity: Major
    Found in app/Module/PlaceHierarchyListModule.php - About 2 hrs to fix

      Method handle has 58 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function handle(ServerRequestInterface $request): ResponseInterface
    {
        $tree     = Validator::attributes($request)->tree();
        $user     = Validator::attributes($request)->user();
        $place_id = Validator::attributes($request)->integer('place_id', 0);
      Severity: Major
      Found in app/Module/PlaceHierarchyListModule.php - About 2 hrs to fix

        Function handle has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            public function handle(ServerRequestInterface $request): ResponseInterface
    {
        $tree     = Validator::attributes($request)->tree();
        $user     = Validator::attributes($request)->user();
        $place_id = Validator::attributes($request)->integer('place_id', 0);
        Severity: Minor
        Found in app/Module/PlaceHierarchyListModule.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function mapData has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function mapData(Place $place): array
    {
        $children  = $place->getChildPlaces();
        $features  = [];
        $sidebar   = '';
        Severity: Minor
        Found in app/Module/PlaceHierarchyListModule.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status