fisharebest/webtrees

View on GitHub
app/Module/RelationshipsChartModule.php

Summary

Maintainability
F
4 days
Test Coverage

File RelationshipsChartModule.php has 489 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * webtrees: online genealogy
 * Copyright (C) 2022 webtrees development team
Severity: Minor
Found in app/Module/RelationshipsChartModule.php - About 7 hrs to fix

    Function chart has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
    Open

        public function chart(Individual $individual1, Individual $individual2, int $recursion, int $ancestors): ResponseInterface
        {
            $tree = $individual1->tree();
    
            $max_recursion = (int) $tree->getPreference('RELATIONSHIP_RECURSION', static::DEFAULT_RECURSION);
    Severity: Minor
    Found in app/Module/RelationshipsChartModule.php - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function calculateRelationships has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

        private function calculateRelationships(
            Individual $individual1,
            Individual $individual2,
            int $recursion,
            bool $ancestor = false
    Severity: Minor
    Found in app/Module/RelationshipsChartModule.php - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method chart has 100 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function chart(Individual $individual1, Individual $individual2, int $recursion, int $ancestors): ResponseInterface
        {
            $tree = $individual1->tree();
    
            $max_recursion = (int) $tree->getPreference('RELATIONSHIP_RECURSION', static::DEFAULT_RECURSION);
    Severity: Major
    Found in app/Module/RelationshipsChartModule.php - About 4 hrs to fix

      Function oldStyleRelationshipPath has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          private function oldStyleRelationshipPath(Tree $tree, array $path): array
          {
              $spouse_codes = [
                  'M' => 'hus',
                  'F' => 'wif',
      Severity: Minor
      Found in app/Module/RelationshipsChartModule.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method calculateRelationships has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function calculateRelationships(
              Individual $individual1,
              Individual $individual2,
              int $recursion,
              bool $ancestor = false
      Severity: Major
      Found in app/Module/RelationshipsChartModule.php - About 2 hrs to fix

        Method handle has 57 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function handle(ServerRequestInterface $request): ResponseInterface
            {
                $tree      = Validator::attributes($request)->tree();
                $xref      = Validator::attributes($request)->isXref()->string('xref');
                $xref2     = Validator::attributes($request)->isXref()->string('xref2', '');
        Severity: Major
        Found in app/Module/RelationshipsChartModule.php - About 2 hrs to fix

          Method oldStyleRelationshipPath has 46 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function oldStyleRelationshipPath(Tree $tree, array $path): array
              {
                  $spouse_codes = [
                      'M' => 'hus',
                      'F' => 'wif',
          Severity: Minor
          Found in app/Module/RelationshipsChartModule.php - About 1 hr to fix

            Consider simplifying this complex logical expression.
            Open

                        if (($rel1 === 'HUSB' || $rel1 === 'WIFE') && ($rel2 === 'HUSB' || $rel2 === 'WIFE')) {
                            $relationships[$i] = $spouse_codes[$next->sex()] ?? $spouse_codes['U'];
                        } elseif (($rel1 === 'HUSB' || $rel1 === 'WIFE') && $rel2 === 'CHIL') {
                            $relationships[$i] = $child_codes[$next->sex()] ?? $child_codes['U'];
                        } elseif ($rel1 === 'CHIL' && ($rel2 === 'HUSB' || $rel2 === 'WIFE')) {
            Severity: Critical
            Found in app/Module/RelationshipsChartModule.php - About 1 hr to fix

              Method allAncestors has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function allAncestors(string $xref1, string $xref2, int $tree_id): array
                  {
                      $ancestors = [
                          $xref1,
                          $xref2,
              Severity: Minor
              Found in app/Module/RelationshipsChartModule.php - About 1 hr to fix

                Function handle has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function handle(ServerRequestInterface $request): ResponseInterface
                    {
                        $tree      = Validator::attributes($request)->tree();
                        $xref      = Validator::attributes($request)->isXref()->string('xref');
                        $xref2     = Validator::attributes($request)->isXref()->string('xref2', '');
                Severity: Minor
                Found in app/Module/RelationshipsChartModule.php - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function allAncestors has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function allAncestors(string $xref1, string $xref2, int $tree_id): array
                    {
                        $ancestors = [
                            $xref1,
                            $xref2,
                Severity: Minor
                Found in app/Module/RelationshipsChartModule.php - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                                $table[$x][$y - 1] = '<div style="background:url(' . e('"' . asset('css/images/vline.png') . '"') . ') repeat-y center; height: 64px; text-align: center;"><div style="display: inline-block; width:50%; line-height: 64px;">' . $this->relationship_service->legacyNameAlgorithm($relationships[$n], Registry::individualFactory()->make($path[$n - 1], $tree), Registry::individualFactory()->make($path[$n + 1], $tree)) . '</div><div style="display: inline-block; width:50%; line-height: 64px;">' . view('icons/arrow-down') . '</div></div>';
                Severity: Major
                Found in app/Module/RelationshipsChartModule.php and 1 other location - About 1 hr to fix
                app/Module/RelationshipsChartModule.php on lines 368..368

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 115.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                                $table[$x][$y + 1] = '<div style="background:url(' . e('"' . asset('css/images/vline.png') . '"') . ') repeat-y center; height: 64px; text-align:center; "><div style="display: inline-block; width: 50%; line-height: 64px;">' . $this->relationship_service->legacyNameAlgorithm($relationships[$n], Registry::individualFactory()->make($path[$n - 1], $tree), Registry::individualFactory()->make($path[$n + 1], $tree)) . '</div><div style="display: inline-block; width: 50%; line-height: 32px">' . view('icons/arrow-up') . '</div></div>';
                Severity: Major
                Found in app/Module/RelationshipsChartModule.php and 1 other location - About 1 hr to fix
                app/Module/RelationshipsChartModule.php on lines 357..357

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 115.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                                $table[$x + 1][$y + 1] = '<div style="background:url(' . $diagonal1 . '); background-position: top right; width: 64px; height: 64px; text-align: center;"><div style="height: 32px; text-align: start;">' . $this->relationship_service->legacyNameAlgorithm($relationships[$n], Registry::individualFactory()->make($path[$n - 1], $tree), Registry::individualFactory()->make($path[$n + 1], $tree)) . '</div><div style="height: 32px; text-align: end;">' . view('icons/arrow-down') . '</div></div>';
                Severity: Minor
                Found in app/Module/RelationshipsChartModule.php and 1 other location - About 40 mins to fix
                app/Module/RelationshipsChartModule.php on lines 354..354

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 93.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                                $table[$x + 1][$y - 1] = '<div style="background:url(' . $diagonal2 . '); width: 64px; height: 64px; text-align: center;"><div style="height: 32px; text-align: end;">' . $this->relationship_service->legacyNameAlgorithm($relationships[$n], Registry::individualFactory()->make($path[$n - 1], $tree), Registry::individualFactory()->make($path[$n + 1], $tree)) . '</div><div style="height: 32px; text-align: start;">' . view('icons/arrow-down') . '</div></div>';
                Severity: Minor
                Found in app/Module/RelationshipsChartModule.php and 1 other location - About 40 mins to fix
                app/Module/RelationshipsChartModule.php on lines 365..365

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 93.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status