fisharebest/webtrees

View on GitHub
app/Report/HtmlRenderer.php

Summary

Maintainability
D
2 days
Test Coverage

File HtmlRenderer.php has 352 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * webtrees: online genealogy
 * Copyright (C) 2022 webtrees development team
Severity: Minor
Found in app/Report/HtmlRenderer.php - About 4 hrs to fix

    HtmlRenderer has 32 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class HtmlRenderer extends AbstractRenderer
    {
        // Cell padding
        public float $cPadding = 2;
    
    
    Severity: Minor
    Found in app/Report/HtmlRenderer.php - About 4 hrs to fix

      Function run has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
      Open

          public function run(): void
          {
              // Setting up the styles
              echo '<style>';
              echo '#bodydiv { font: 10px sans-serif;}';
      Severity: Minor
      Found in app/Report/HtmlRenderer.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method run has 68 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function run(): void
          {
              // Setting up the styles
              echo '<style>';
              echo '#bodydiv { font: 10px sans-serif;}';
      Severity: Major
      Found in app/Report/HtmlRenderer.php - About 2 hrs to fix

        Method createCell has 14 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function createCell(float $width, float $height, string $border, string $align, string $bgcolor, string $style, int $ln, $top, $left, int $fill, int $stretch, string $bocolor, string $tcolor, bool $reseth): ReportBaseCell
        Severity: Major
        Found in app/Report/HtmlRenderer.php - About 1 hr to fix

          Method createTextBox has 12 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  float $width,
                  float $height,
                  bool $border,
                  string $bgcolor,
                  bool $newline,
          Severity: Major
          Found in app/Report/HtmlRenderer.php - About 1 hr to fix

            Function utf8WordWrap has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

                private function utf8WordWrap(string $string, int $width): string
                {
                    $out = '';
                    while ($string) {
                        if (mb_strlen($string) <= $width) {
            Severity: Minor
            Found in app/Report/HtmlRenderer.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method createImageFromObject has 8 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    MediaFile $media_file,
                    float $x,
                    float $y,
                    float $w,
                    float $h,
            Severity: Major
            Found in app/Report/HtmlRenderer.php - About 1 hr to fix

              Method createImage has 7 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function createImage(string $file, float $x, float $y, float $w, float $h, string $align, string $ln): ReportBaseImage
              Severity: Major
              Found in app/Report/HtmlRenderer.php - About 50 mins to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function createCell(float $width, float $height, string $border, string $align, string $bgcolor, string $style, int $ln, $top, $left, int $fill, int $stretch, string $bocolor, string $tcolor, bool $reseth): ReportBaseCell
                    {
                        return new ReportHtmlCell($width, $height, $border, $align, $bgcolor, $style, $ln, $top, $left, $fill, $stretch, $bocolor, $tcolor, $reseth);
                    }
                Severity: Major
                Found in app/Report/HtmlRenderer.php and 1 other location - About 1 hr to fix
                app/Report/PdfRenderer.php on lines 428..431

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 112.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function createTextBox(
                        float $width,
                        float $height,
                        bool $border,
                        string $bgcolor,
                Severity: Minor
                Found in app/Report/HtmlRenderer.php and 1 other location - About 55 mins to fix
                app/Report/PdfRenderer.php on lines 451..466

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 98.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status