fisharebest/webtrees

View on GitHub
app/Services/AdminService.php

Summary

Maintainability
D
2 days
Test Coverage

Method duplicateRecords has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function duplicateRecords(Tree $tree): array
    {
        // We can't do any reasonable checks using MySQL.
        // Will need to wait for a "repositories" table.
        $repositories = [];
Severity: Major
Found in app/Services/AdminService.php - About 2 hrs to fix

    Method duplicateXrefs has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function duplicateXrefs(Tree $tree): array
        {
            $subquery1 = DB::table('individuals')
                ->where('i_file', '=', $tree->id())
                ->select(['i_id AS xref', new Expression("'INDI' AS type")])
    Severity: Minor
    Found in app/Services/AdminService.php - About 1 hr to fix

      Method countCommonXrefs has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function countCommonXrefs(Tree $tree1, Tree $tree2): int
          {
              $subquery1 = DB::table('individuals')
                  ->where('i_file', '=', $tree1->id())
                  ->select(['i_id AS xref'])
      Severity: Minor
      Found in app/Services/AdminService.php - About 1 hr to fix

        Avoid too many return statements within this method.
        Open

                return [
                    I18N::translate('Repositories')  => $repositories,
                    I18N::translate('Sources')       => $sources,
                    I18N::translate('Individuals')   => $individuals,
                    I18N::translate('Families')      => $families,
        Severity: Major
        Found in app/Services/AdminService.php - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  $subquery2 = DB::table('change')
                      ->where('gedcom_id', '=', $tree2->id())
                      ->select(['xref AS other_xref'])
                      ->union(DB::table('individuals')
                          ->where('i_file', '=', $tree2->id())
          Severity: Major
          Found in app/Services/AdminService.php and 1 other location - About 1 day to fix
          app/Services/AdminService.php on lines 216..234

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 248.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  $subquery2 = DB::table('change')
                      ->where('gedcom_id', '<>', $tree->id())
                      ->select(['xref AS other_xref'])
                      ->union(DB::table('individuals')
                          ->where('i_file', '<>', $tree->id())
          Severity: Major
          Found in app/Services/AdminService.php and 1 other location - About 1 day to fix
          app/Services/AdminService.php on lines 79..97

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 248.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status