fisharebest/webtrees

Method duplicateRecords has 69 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function duplicateRecords(Tree $tree): array
    {
        // We can't do any reasonable checks using MySQL.
        // Will need to wait for a "repositories" table.
        $repositories = [];

Method duplicateXrefs has 40 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function duplicateXrefs(Tree $tree): array
    {
        $subquery1 = DB::table('individuals')
            ->where('i_file', '=', $tree->id())
            ->select(['i_id AS xref', new Expression("'INDI' AS type")])

Method countCommonXrefs has 39 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function countCommonXrefs(Tree $tree1, Tree $tree2): int
    {
        $subquery1 = DB::table('individuals')
            ->where('i_file', '=', $tree1->id())
            ->select(['i_id AS xref'])

Avoid too many return statements within this method.

Open

        return [
            I18N::translate('Repositories')  => $repositories,
            I18N::translate('Sources')       => $sources,
            I18N::translate('Individuals')   => $individuals,
            I18N::translate('Families')      => $families,

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        $subquery2 = DB::table('change')
            ->where('gedcom_id', '<>', $tree->id())
            ->select(['xref AS other_xref'])
            ->union(DB::table('individuals')
                ->where('i_file', '<>', $tree->id())

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        $subquery2 = DB::table('change')
            ->where('gedcom_id', '=', $tree2->id())
            ->select(['xref AS other_xref'])
            ->union(DB::table('individuals')
                ->where('i_file', '=', $tree2->id())

• Read up
  Read up