fisharebest/webtrees

View on GitHub
app/Services/CalendarService.php

Summary

Maintainability
F
5 days
Test Coverage

Function getAnniversaryEvents has a Cognitive Complexity of 56 (exceeds 5 allowed). Consider refactoring.
Open

    public function getAnniversaryEvents(int $jd, string $facts, Tree $tree, string $filterof = '', string $filtersx = ''): array
    {
        $found_facts = [];

        $anniversaries = [
Severity: Minor
Found in app/Services/CalendarService.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getCalendarEvents has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    public function getCalendarEvents(int $jd1, int $jd2, string $facts, Tree $tree, string $filterof = '', string $filtersx = ''): array
    {
        // Events that start or end during the period
        $query = DB::table('dates')
            ->where('d_file', '=', $tree->id())
Severity: Minor
Found in app/Services/CalendarService.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File CalendarService.php has 356 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * webtrees: online genealogy
 * Copyright (C) 2022 webtrees development team
Severity: Minor
Found in app/Services/CalendarService.php - About 4 hrs to fix

    Function getEventsList has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getEventsList(int $jd1, int $jd2, string $events, bool $only_living, string $sort_by, Tree $tree): Collection
        {
            $found_facts = [];
            $facts       = new Collection();
    
    
    Severity: Minor
    Found in app/Services/CalendarService.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getAnniversaryEvents has 97 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getAnniversaryEvents(int $jd, string $facts, Tree $tree, string $filterof = '', string $filtersx = ''): array
        {
            $found_facts = [];
    
            $anniversaries = [
    Severity: Major
    Found in app/Services/CalendarService.php - About 3 hrs to fix

      Method getCalendarEvents has 66 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getCalendarEvents(int $jd1, int $jd2, string $facts, Tree $tree, string $filterof = '', string $filtersx = ''): array
          {
              // Events that start or end during the period
              $query = DB::table('dates')
                  ->where('d_file', '=', $tree->id())
      Severity: Major
      Found in app/Services/CalendarService.php - About 2 hrs to fix

        Method getEventsList has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getEventsList(int $jd1, int $jd2, string $events, bool $only_living, string $sort_by, Tree $tree): Collection
            {
                $found_facts = [];
                $facts       = new Collection();
        
        
        Severity: Minor
        Found in app/Services/CalendarService.php - About 1 hr to fix

          Function calendarMonthsInYear has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public function calendarMonthsInYear(string $calendar, int $year): array
              {
                  $date          = new Date($calendar . ' ' . $year);
                  $calendar_date = $date->minimumDate();
                  $month_numbers = range(1, $calendar_date->monthsInYear());
          Severity: Minor
          Found in app/Services/CalendarService.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method getEventsList has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function getEventsList(int $jd1, int $jd2, string $events, bool $only_living, string $sort_by, Tree $tree): Collection
          Severity: Minor
          Found in app/Services/CalendarService.php - About 45 mins to fix

            Method getCalendarEvents has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function getCalendarEvents(int $jd1, int $jd2, string $facts, Tree $tree, string $filterof = '', string $filtersx = ''): array
            Severity: Minor
            Found in app/Services/CalendarService.php - About 45 mins to fix

              Method getAnniversaryEvents has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function getAnniversaryEvents(int $jd, string $facts, Tree $tree, string $filterof = '', string $filtersx = ''): array
              Severity: Minor
              Found in app/Services/CalendarService.php - About 35 mins to fix

                Function adarIIAnniversaries has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function adarIIAnniversaries(Builder $query, JewishDate $anniv): void
                    {
                        if ($anniv->day() === 1) {
                            $query->where('d_day', '<=', 1);
                        } elseif ($anniv->day() === $anniv->daysInMonth()) {
                Severity: Minor
                Found in app/Services/CalendarService.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                                    if ($type === 'INDI') {
                                        $record = Registry::individualFactory()->make($row->xref, $tree, $row->gedcom);
                                        assert($record instanceof Individual);
                
                                        if ($filterof === 'living' && $record->isDead()) {
                Severity: Major
                Found in app/Services/CalendarService.php and 1 other location - About 4 hrs to fix
                app/Services/CalendarService.php on lines 160..176

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 165.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                                if ($type === 'INDI') {
                                    $record = Registry::individualFactory()->make($row->xref, $tree, $row->gedcom);
                                    assert($record instanceof Individual);
                
                                    if ($filterof === 'living' && $record->isDead()) {
                Severity: Major
                Found in app/Services/CalendarService.php and 1 other location - About 4 hrs to fix
                app/Services/CalendarService.php on lines 364..380

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 165.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                        if ($anniv->day === 1 && $tmp->daysInMonth() === 29) {
                            $query->where(static function (Builder $query): void {
                                $query->where(static function (Builder $query): void {
                                    $query->where('d_day', '<=', 1)->where('d_mon', '=', 4);
                                })->orWhere(static function (Builder $query): void {
                Severity: Major
                Found in app/Services/CalendarService.php and 2 other locations - About 1 hr to fix
                app/Services/CalendarService.php on lines 452..467
                app/Services/CalendarService.php on lines 528..538

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 112.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                        if ($anniv->day() === 1 && $tmp->daysInMonth() === 29) {
                            $query->where(static function (Builder $query): void {
                                $query->where(static function (Builder $query): void {
                                    $query->where('d_day', '<=', 1)->where('d_mon', '=', 3);
                                })->orWhere(static function (Builder $query): void {
                Severity: Major
                Found in app/Services/CalendarService.php and 2 other locations - About 1 hr to fix
                app/Services/CalendarService.php on lines 480..490
                app/Services/CalendarService.php on lines 528..538

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 112.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                        if ($anniv->day === 1 && !$anniv->isLeapYear()) {
                            $query->where(static function (Builder $query): void {
                                $query->where(static function (Builder $query): void {
                                    $query->where('d_day', '<=', 1)->where('d_mon', '=', 8);
                                })->orWhere(static function (Builder $query): void {
                Severity: Major
                Found in app/Services/CalendarService.php and 2 other locations - About 1 hr to fix
                app/Services/CalendarService.php on lines 452..467
                app/Services/CalendarService.php on lines 480..490

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 112.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status