Sign upLogin

fisharebest/webtrees

View on GitHub
Star
app/Services/DatatablesService.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method handleCollection has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function handleCollection(ServerRequestInterface $request, Collection $collection, array $search_columns, array $sort_columns, Closure $callback): ResponseInterface
    {
        $search = Validator::queryParams($request)->array('search')['value'] ?? '';
        $start  = Validator::queryParams($request)->integer('start', 0);
        $length = Validator::queryParams($request)->integer('length', 0);
Severity: Minor
Found in app/Services/DatatablesService.php - About 1 hr to fix

    Method handleQuery has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function handleQuery(ServerRequestInterface $request, Builder $query, array $search_columns, array $sort_columns, Closure $callback): ResponseInterface
    {
        $search = Validator::queryParams($request)->array('search')['value'] ?? '';
        $start  = Validator::queryParams($request)->integer('start', 0);
        $length = Validator::queryParams($request)->integer('length', 0);
    Severity: Minor
    Found in app/Services/DatatablesService.php - About 1 hr to fix

      Method handleQuery has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function handleQuery(ServerRequestInterface $request, Builder $query, array $search_columns, array $sort_columns, Closure $callback): ResponseInterface
      Severity: Minor
      Found in app/Services/DatatablesService.php - About 35 mins to fix

        Method handleCollection has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function handleCollection(ServerRequestInterface $request, Collection $collection, array $search_columns, array $sort_columns, Closure $callback): ResponseInterface
        Severity: Minor
        Found in app/Services/DatatablesService.php - About 35 mins to fix

          Function handleQuery has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public function handleQuery(ServerRequestInterface $request, Builder $query, array $search_columns, array $sort_columns, Closure $callback): ResponseInterface
    {
        $search = Validator::queryParams($request)->array('search')['value'] ?? '';
        $start  = Validator::queryParams($request)->integer('start', 0);
        $length = Validator::queryParams($request)->integer('length', 0);
          Severity: Minor
          Found in app/Services/DatatablesService.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                  return response([
            'draw'            => $draw,
            'recordsTotal'    => $recordsTotal,
            'recordsFiltered' => $recordsFiltered,
            'data'            => $data,
          Severity: Major
          Found in app/Services/DatatablesService.php - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status