Sign upLogin

fisharebest/webtrees

View on GitHub
Star
app/Services/GedcomEditService.php

Summary

Maintainability
C
1 day
Test Coverage

Function editLinesToGedcom has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

    public function editLinesToGedcom(string $record_type, array $levels, array $tags, array $values, bool $append = true): string
    {
        // Assert all arrays are the same size.
        $count = count($levels);
        assert($count > 0);
Severity: Minor
Found in app/Services/GedcomEditService.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function insertMissingLevels has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    protected function insertMissingLevels(Tree $tree, string $tag, string $gedcom, bool $include_hidden): string
    {
        $next_level = substr_count($tag, ':') + 1;
        $factory    = Registry::elementFactory();
        $subtags    = $factory->make($tag)->subtags();
Severity: Minor
Found in app/Services/GedcomEditService.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method editLinesToGedcom has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function editLinesToGedcom(string $record_type, array $levels, array $tags, array $values, bool $append = true): string
    {
        // Assert all arrays are the same size.
        $count = count($levels);
        assert($count > 0);
Severity: Minor
Found in app/Services/GedcomEditService.php - About 1 hr to fix

    Method insertMissingLevels has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function insertMissingLevels(Tree $tree, string $tag, string $gedcom, bool $include_hidden): string
    {
        $next_level = substr_count($tag, ':') + 1;
        $factory    = Registry::elementFactory();
        $subtags    = $factory->make($tag)->subtags();
    Severity: Minor
    Found in app/Services/GedcomEditService.php - About 1 hr to fix

      Method editLinesToGedcom has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function editLinesToGedcom(string $record_type, array $levels, array $tags, array $values, bool $append = true): string
      Severity: Minor
      Found in app/Services/GedcomEditService.php - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status