fisharebest/webtrees

View on GitHub
app/Statistics/Google/ChartMarriageAge.php

Summary

Maintainability
F
4 days
Test Coverage

Method queryRecords has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function queryRecords(): Collection
    {
        $prefix = DB::connection()->getTablePrefix();

        $male = DB::table('dates as married')
Severity: Major
Found in app/Statistics/Google/ChartMarriageAge.php - About 2 hrs to fix

    Method chartMarriageAge has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function chartMarriageAge(): string
        {
            $out = [];
    
            foreach ($this->queryRecords() as $record) {
    Severity: Minor
    Found in app/Statistics/Google/ChartMarriageAge.php - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function chartMarriageAge(): string
          {
              $out = [];
      
              foreach ($this->queryRecords() as $record) {
      Severity: Major
      Found in app/Statistics/Google/ChartMarriageAge.php and 1 other location - About 1 day to fix
      app/Statistics/Google/ChartAge.php on lines 103..157

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 348.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              $male = DB::table('dates as married')
                  ->select([
                      new Expression('AVG(' . $prefix . 'married.d_julianday2 - ' . $prefix . 'birth.d_julianday1 - 182.5) / 365.25 AS age'),
                      new Expression('ROUND((' . $prefix . 'married.d_year + 49) / 100) AS century'),
                      new Expression("'M' as sex")
      Severity: Major
      Found in app/Statistics/Google/ChartMarriageAge.php and 1 other location - About 1 day to fix
      app/Statistics/Google/ChartMarriageAge.php on lines 85..106

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 279.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              $female = DB::table('dates as married')
                  ->select([
                      new Expression('ROUND(AVG(' . $prefix . 'married.d_julianday2 - ' . $prefix . 'birth.d_julianday1 - 182.5) / 365.25, 1) AS age'),
                      new Expression('ROUND((' . $prefix . 'married.d_year + 49) / 100) AS century'),
                      new Expression("'F' as sex")
      Severity: Major
      Found in app/Statistics/Google/ChartMarriageAge.php and 1 other location - About 1 day to fix
      app/Statistics/Google/ChartMarriageAge.php on lines 62..83

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 279.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status