flavors/django-graphql-jwt

View on GitHub

Showing 12 of 12 total issues

Cyclomatic complexity is too high in method resolve. (11)
Open

    def resolve(self, next, root, info, **kwargs):
        context = info.context
        token_argument = get_token_argument(context, **kwargs)

        if jwt_settings.JWT_ALLOW_ARGUMENT and token_argument is None:
Severity: Minor
Found in graphql_jwt/middleware.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Function resolve has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def resolve(self, next, root, info, **kwargs):
        context = info.context
        token_argument = get_token_argument(context, **kwargs)

        if jwt_settings.JWT_ALLOW_ARGUMENT and token_argument is None:
Severity: Minor
Found in graphql_jwt/middleware.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function token_auth has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

def token_auth(f):
    @wraps(f)
    @setup_jwt_cookie
    def wrapper(cls, root, info, password, **kwargs):
        context = info.context
Severity: Minor
Found in graphql_jwt/decorators.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function mutate_and_get_payload has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def mutate_and_get_payload(cls, root, info, token, **kwargs):
Severity: Minor
Found in graphql_jwt/relay.py - About 35 mins to fix

    Function wrapper has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def wrapper(cls, root, info, *args, **kwargs):
    Severity: Minor
    Found in graphql_jwt/decorators.py - About 35 mins to fix

      Function wrapper has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def wrapper(cls, root, info, password, **kwargs):
      Severity: Minor
      Found in graphql_jwt/decorators.py - About 35 mins to fix

        Function refresh has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def refresh(cls, root, info, refresh_token, **kwargs):
        Severity: Minor
        Found in graphql_jwt/refresh_token/mixins.py - About 35 mins to fix

          Function mutate has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def mutate(cls, root, info, token, **kwargs):
          Severity: Minor
          Found in graphql_jwt/mutations.py - About 35 mins to fix

            Function refresh has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def refresh(cls, root, info, token, **kwargs):
            Severity: Minor
            Found in graphql_jwt/mixins.py - About 35 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              token_refreshed = Signal(providing_args=['request', 'user'])
              Severity: Minor
              Found in graphql_jwt/signals.py and 1 other location - About 30 mins to fix
              graphql_jwt/refresh_token/signals.py on lines 0..4

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 32.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              refresh_token_rotated = Signal(providing_args=['request', 'refresh_token'])
              Severity: Minor
              Found in graphql_jwt/refresh_token/signals.py and 1 other location - About 30 mins to fix
              graphql_jwt/signals.py on lines 0..4

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 32.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function parent has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  def parent(self, path):
                      path = filter_strings(path)
              
                      for depth in range(len(path) - 1):
                          parent = path[:-1 - depth]
              Severity: Minor
              Found in graphql_jwt/path.py - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language