Sign upLogin

fnando/browser

View on GitHub
Star

Showing 7 of 10 total issues

Class Base has 43 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Base
    include DetectVersion

    attr_reader :ua
Severity: Minor
Found in lib/browser/base.rb - About 5 hrs to fix

    Class Platform has 34 methods (exceeds 20 allowed). Consider refactoring.
    Open

      class Platform
    include DetectVersion

    attr_reader :ua
    Severity: Minor
    Found in lib/browser/platform.rb - About 4 hrs to fix

      Class Device has 32 methods (exceeds 20 allowed). Consider refactoring.
      Open

        class Device
    attr_reader :ua

    # Hold the list of device matchers.
    # Order is important.
      Severity: Minor
      Found in lib/browser/device.rb - About 4 hrs to fix

        Method matchers has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def self.matchers
    @matchers ||= [
      Nokia,
      UCBrowser,
      PhantomJS,
        Severity: Minor
        Found in lib/browser/browser.rb - About 1 hr to fix

          Method detect_version? has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              private def detect_version?(actual_version, expected_version)
      return true unless expected_version
      return false if expected_version && !actual_version

      expected_version = parse_version(expected_version)
          Severity: Minor
          Found in lib/browser/detect_version.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def match?
      ua =~ /Safari/ &&
        ua !~ /PhantomJS|FxiOS/ &&
        !edge? &&
        !chrome? &&
          Severity: Minor
          Found in lib/browser/safari.rb and 1 other location - About 35 mins to fix
          lib/browser/chrome.rb on lines 22..33

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 34.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def match?
      ua =~ /Chrome|CriOS/ &&
        ua !~ /PhantomJS|FxiOS|ArchiveBot/ &&
        !opera? &&
        !edge? &&
          Severity: Minor
          Found in lib/browser/chrome.rb and 1 other location - About 35 mins to fix
          lib/browser/safari.rb on lines 20..31

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 34.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language