Sign upLogin

fog/fog-digitalocean

View on GitHub
Star

Showing 65 of 65 total issues

Method list_volumes has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def list_volumes(filters = {})
          response        = Excon::Response.new
                    response.status = 200
                    response.body   = {
                        "volumes" => [
Severity: Minor
Found in lib/fog/compute/digitalocean/requests/list_volumes.rb - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          class Real
        def detach_volume(volume_id, droplet_id, region)
          body = { :type => 'detach', droplet_id: droplet_id, region: region}

          encoded_body = Fog::JSON.encode(body)
    Severity: Major
    Found in lib/fog/compute/digitalocean/requests/detach_volume.rb and 1 other location - About 1 hr to fix
    lib/fog/compute/digitalocean/requests/attach_volume.rb on lines 4..34

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 66.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          class Real
        def attach_volume(volume_id, droplet_id, region)
          body = { :type => 'attach', droplet_id: droplet_id, region: region}

          encoded_body = Fog::JSON.encode(body)
    Severity: Major
    Found in lib/fog/compute/digitalocean/requests/attach_volume.rb and 1 other location - About 1 hr to fix
    lib/fog/compute/digitalocean/requests/detach_volume.rb on lines 4..33

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 66.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method resize_volume has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def resize_volume(volume_id, size, region)
                    response         = Excon::Response.new
                    response.status  = 201
          response.body    = {
            "action" => {
    Severity: Minor
    Found in lib/fog/compute/digitalocean/requests/resize_volume.rb - About 1 hr to fix

      Method attach_volume_by_name has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              def attach_volume_by_name(volume_name, droplet_id, region)
                    response         = Excon::Response.new
                    response.status  = 201
                    response.body    = {
                        "action" => {
      Severity: Minor
      Found in lib/fog/compute/digitalocean/requests/attach_volume.rb - About 1 hr to fix

        Method detach_volume has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                def detach_volume(volume_id, droplet_id, region)
          response         = Excon::Response.new
          response.status  = 201
                    response.body    = {
                        "action" => {
        Severity: Minor
        Found in lib/fog/compute/digitalocean/requests/detach_volume.rb - About 1 hr to fix

          Method create_server has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  def create_server(name,
                          size,
                          image,
                          region,
                          options = {})
          Severity: Minor
          Found in lib/fog/compute/digitalocean/requests/create_server.rb - About 1 hr to fix

            Method detach_volume_by_name has 37 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    def detach_volume_by_name(volume_name, droplet_id, region)
          response         = Excon::Response.new
          response.status  = 201
                    response.body    = {
                        "action" => {
            Severity: Minor
            Found in lib/fog/compute/digitalocean/requests/detach_volume.rb - About 1 hr to fix

              Method attach_volume has 37 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      def attach_volume(volume_id, droplet_id, region)
                    response         = Excon::Response.new
                    response.status  = 201
                    response.body    = {
                        "action" => {
              Severity: Minor
              Found in lib/fog/compute/digitalocean/requests/attach_volume.rb - About 1 hr to fix

                Method get_volume_details has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        def get_volume_details(_)
          response        = Excon::Response.new
          response.status = 200

          response.body = {
                Severity: Minor
                Found in lib/fog/compute/digitalocean/requests/get_volume_details.rb - About 1 hr to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          def detach_volume_by_name(volume_name, droplet_id, region)
          response         = Excon::Response.new
          response.status  = 201
                    response.body    = {
                        "action" => {
                  Severity: Major
                  Found in lib/fog/compute/digitalocean/requests/detach_volume.rb and 1 other location - About 1 hr to fix
                  lib/fog/compute/digitalocean/requests/detach_volume.rb on lines 38..76

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 56.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          def detach_volume(volume_id, droplet_id, region)
          response         = Excon::Response.new
          response.status  = 201
                    response.body    = {
                        "action" => {
                  Severity: Major
                  Found in lib/fog/compute/digitalocean/requests/detach_volume.rb and 1 other location - About 1 hr to fix
                  lib/fog/compute/digitalocean/requests/detach_volume.rb on lines 78..116

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 56.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                  module Fog
  module Compute
    class DigitalOcean
      class Volumes < Fog::Compute::DigitalOcean::PagingCollection
        model Fog::Compute::DigitalOcean::Volume
                  Severity: Major
                  Found in lib/fog/compute/digitalocean/models/volumes.rb and 3 other locations - About 1 hr to fix
                  lib/fog/compute/digitalocean/models/images.rb on lines 3..36
                  lib/fog/compute/digitalocean/models/servers.rb on lines 5..38
                  lib/fog/compute/digitalocean/models/ssh_keys.rb on lines 3..35

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 56.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          def attach_volume_by_name(volume_name, droplet_id, region)
                    response         = Excon::Response.new
                    response.status  = 201
                    response.body    = {
                        "action" => {
                  Severity: Major
                  Found in lib/fog/compute/digitalocean/requests/attach_volume.rb and 1 other location - About 1 hr to fix
                  lib/fog/compute/digitalocean/requests/attach_volume.rb on lines 39..77

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 56.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                  module Fog
  module Compute
    class DigitalOcean
      class Servers < Fog::Compute::DigitalOcean::PagingCollection
        model Fog::Compute::DigitalOcean::Server
                  Severity: Major
                  Found in lib/fog/compute/digitalocean/models/servers.rb and 3 other locations - About 1 hr to fix
                  lib/fog/compute/digitalocean/models/images.rb on lines 3..36
                  lib/fog/compute/digitalocean/models/ssh_keys.rb on lines 3..35
                  lib/fog/compute/digitalocean/models/volumes.rb on lines 3..36

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 56.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                  module Fog
  module Compute
    class DigitalOcean
      class Images < Fog::Compute::DigitalOcean::PagingCollection
        model Fog::Compute::DigitalOcean::Image
                  Severity: Major
                  Found in lib/fog/compute/digitalocean/models/images.rb and 3 other locations - About 1 hr to fix
                  lib/fog/compute/digitalocean/models/servers.rb on lines 5..38
                  lib/fog/compute/digitalocean/models/ssh_keys.rb on lines 3..35
                  lib/fog/compute/digitalocean/models/volumes.rb on lines 3..36

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 56.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                  module Fog
  module Compute
    class DigitalOcean
      class SshKeys < Fog::Compute::DigitalOcean::PagingCollection
        model Fog::Compute::DigitalOcean::SshKey
                  Severity: Major
                  Found in lib/fog/compute/digitalocean/models/ssh_keys.rb and 3 other locations - About 1 hr to fix
                  lib/fog/compute/digitalocean/models/images.rb on lines 3..36
                  lib/fog/compute/digitalocean/models/servers.rb on lines 5..38
                  lib/fog/compute/digitalocean/models/volumes.rb on lines 3..36

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 56.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          def attach_volume(volume_id, droplet_id, region)
                    response         = Excon::Response.new
                    response.status  = 201
                    response.body    = {
                        "action" => {
                  Severity: Major
                  Found in lib/fog/compute/digitalocean/requests/attach_volume.rb and 1 other location - About 1 hr to fix
                  lib/fog/compute/digitalocean/requests/attach_volume.rb on lines 79..117

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 56.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method list_images has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          def list_images(filters = {})
          next_page = (filters[:page] || 1).to_i + 1

          response        = Excon::Response.new
          response.status = 200
                  Severity: Minor
                  Found in lib/fog/compute/digitalocean/requests/list_images.rb - About 1 hr to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                      module Compute
    class DigitalOcean
      # noinspection RubyStringKeysInHashInspection
      class Real
        def delete_ssh_key(id)
                    Severity: Minor
                    Found in lib/fog/compute/digitalocean/requests/delete_ssh_key.rb and 1 other location - About 50 mins to fix
                    lib/fog/compute/digitalocean/requests/destroy_volume.rb on lines 2..27

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 43.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Severity
                    Category
                    Status
                    Source
                    Language