Sign upLogin

fog/fog-digitalocean

View on GitHub
Star
lib/fog/compute/digitalocean/requests/detach_volume.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method detach_volume has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def detach_volume(volume_id, droplet_id, region)
          response         = Excon::Response.new
          response.status  = 201
                    response.body    = {
                        "action" => {
Severity: Minor
Found in lib/fog/compute/digitalocean/requests/detach_volume.rb - About 1 hr to fix

    Method detach_volume_by_name has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def detach_volume_by_name(volume_name, droplet_id, region)
          response         = Excon::Response.new
          response.status  = 201
                    response.body    = {
                        "action" => {
    Severity: Minor
    Found in lib/fog/compute/digitalocean/requests/detach_volume.rb - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            class Real
        def detach_volume(volume_id, droplet_id, region)
          body = { :type => 'detach', droplet_id: droplet_id, region: region}

          encoded_body = Fog::JSON.encode(body)
      Severity: Major
      Found in lib/fog/compute/digitalocean/requests/detach_volume.rb and 1 other location - About 1 hr to fix
      lib/fog/compute/digitalocean/requests/attach_volume.rb on lines 4..34

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              def detach_volume_by_name(volume_name, droplet_id, region)
          response         = Excon::Response.new
          response.status  = 201
                    response.body    = {
                        "action" => {
      Severity: Major
      Found in lib/fog/compute/digitalocean/requests/detach_volume.rb and 1 other location - About 1 hr to fix
      lib/fog/compute/digitalocean/requests/detach_volume.rb on lines 38..76

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 56.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              def detach_volume(volume_id, droplet_id, region)
          response         = Excon::Response.new
          response.status  = 201
                    response.body    = {
                        "action" => {
      Severity: Major
      Found in lib/fog/compute/digitalocean/requests/detach_volume.rb and 1 other location - About 1 hr to fix
      lib/fog/compute/digitalocean/requests/detach_volume.rb on lines 78..116

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 56.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status