fog/fog-profitbricks

View on GitHub
lib/fog/profitbricks/models/compute/server.rb

Summary

Maintainability
C
1 day
Test Coverage

Method get_firewall_rules has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

        def get_firewall_rules(firewall_rules)
          items = []
          for firewall_rule in firewall_rules do
            item = {}
            item[:name]           = firewall_rule[:name] if firewall_rule.key?(:name)
Severity: Minor
Found in lib/fog/profitbricks/models/compute/server.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class Server has 22 methods (exceeds 20 allowed). Consider refactoring.
Open

      class Server < Fog::Models::ProfitBricks::Base
        include Fog::Helpers::ProfitBricks::DataHelper

        identity  :id

Severity: Minor
Found in lib/fog/profitbricks/models/compute/server.rb - About 2 hrs to fix

    Method get_nics has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

            def get_nics(nics)
              items = []
              for nic in nics do
                firewall_rules = nil
                item = {}
    Severity: Minor
    Found in lib/fog/profitbricks/models/compute/server.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method save has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

            def save
              requires :datacenter_id, :name, :cores, :ram
    
              properties = {}
              properties[:name]             = name if name
    Severity: Minor
    Found in lib/fog/profitbricks/models/compute/server.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method update has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            def update
              requires :datacenter_id, :id
    
              properties = {}
              properties[:name]             = name if name
    Severity: Minor
    Found in lib/fog/profitbricks/models/compute/server.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                item = {}
                item[:name]           = firewall_rule[:name] if firewall_rule.key?(:name)
                item[:protocol]       = firewall_rule[:protocol] if firewall_rule.key?(:protocol)
                item[:sourceMac]      = firewall_rule[:source_mac] if firewall_rule.key?(:source_mac)
                item[:sourceIp]       = firewall_rule[:source_ip] if firewall_rule.key?(:source_ip)
    Severity: Major
    Found in lib/fog/profitbricks/models/compute/server.rb and 1 other location - About 2 hrs to fix
    lib/fog/profitbricks/models/compute/nic.rb on lines 99..109

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 98.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            def list_cdroms
              requires :datacenter_id, :id
    
              result = service.list_attached_cdroms(datacenter_id, id)
    
    
    Severity: Minor
    Found in lib/fog/profitbricks/models/compute/server.rb and 1 other location - About 25 mins to fix
    lib/fog/profitbricks/models/compute/server.rb on lines 169..177

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 29.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            def list_volumes
              requires :datacenter_id, :id
    
              result = service.list_attached_volumes(datacenter_id, id)
    
    
    Severity: Minor
    Found in lib/fog/profitbricks/models/compute/server.rb and 1 other location - About 25 mins to fix
    lib/fog/profitbricks/models/compute/server.rb on lines 180..188

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 29.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 4 locations. Consider refactoring.
    Open

            def reload
              requires :datacenter_id, :id
    
              data = begin
                collection.get(datacenter_id, id)
    Severity: Minor
    Found in lib/fog/profitbricks/models/compute/server.rb and 3 other locations - About 15 mins to fix
    lib/fog/profitbricks/models/compute/lan.rb on lines 67..80
    lib/fog/profitbricks/models/compute/load_balancer.rb on lines 69..82
    lib/fog/profitbricks/models/compute/volume.rb on lines 88..101

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 26.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status