Showing 248 of 460 total issues

Method initialize has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

      def initialize
        desc "Update the changelog since the last release"
        task(:github_release) do

          File.open('CHANGELOG.md', 'r') do |file|
Severity: Minor
Found in lib/tasks/github_release_task.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method do_request has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def do_request(params)
          headers = {
            'Accept' => "application/*+xml;version=#{@api_version}",
            'x-vcloud-authorization' => vcloud_token
          }
Severity: Minor
Found in lib/fog/vcloud_director/compute.rb - About 1 hr to fix

    Method list_offerings has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def list_offerings
              response = Excon::Response.new
              response.status = 200
              response.body = {"volumes"=>
                  [{"name"=>"Small",
    Severity: Minor
    Found in lib/fog/ibm/requests/storage/list_offerings.rb - About 1 hr to fix

      Method get_organizations_from_query has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              def get_organizations_from_query(options={})
                query = []
                query << "sortAsc=#{options[:sortAsc]}" if options[:sortAsc]
                query << "sortDesc=#{options[:sortDesc]}" if options[:sortDesc]
                query << "page=#{options[:page]}" if options[:page]

        Method get_catalogs_from_query has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                def get_catalogs_from_query(options={})
                  query = []
                  query << "sortAsc=#{options[:sortAsc]}" if options[:sortAsc]
                  query << "sortDesc=#{options[:sortDesc]}" if options[:sortDesc]
                  query << "page=#{options[:page]}" if options[:page]
        Severity: Minor
        Found in lib/fog/vcloud_director/requests/compute/get_catalogs_from_query.rb - About 1 hr to fix

          Method build_firewall_service has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                    def build_firewall_service(xml)
                      firewall_config = @configuration[:FirewallService]
                      return unless firewall_config
          
                      xml.FirewallService {

            Method request has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    def request(params)
                      begin
                        response = @connection.request(params.merge({
                          :headers  => {
                            'Content-Type' => 'application/json',
            Severity: Minor
            Found in lib/fog/clodo/compute.rb - About 1 hr to fix

              Method container_get has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      def container_get(id)
                        {'id'                         => '2ce79789656e4f7474624be6496dc6d988899af30d556574389a19aade2f9650',
                         'image'                      => 'mattdm/fedora:f19',
                         'command'                    => '/bin/bash',
                         'created'                    => '1389876158',
              Severity: Minor
              Found in lib/fog/fogdocker/requests/compute/container_get.rb - About 1 hr to fix

                Method get_disks_from_query has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        def get_disks_from_query(options={})
                          query = []
                          query << "sortAsc=#{options[:sortAsc]}" if options[:sortAsc]
                          query << "sortDesc=#{options[:sortDesc]}" if options[:sortDesc]
                          query << "page=#{options[:page]}" if options[:page]
                Severity: Minor
                Found in lib/fog/vcloud_director/requests/compute/get_disks_from_query.rb - About 1 hr to fix

                  Method get_users_from_query has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          def get_users_from_query(options={})
                            query = []
                            query << "sortAsc=#{options[:sortAsc]}" if options[:sortAsc]
                            query << "sortDesc=#{options[:sortDesc]}" if options[:sortDesc]
                            query << "page=#{options[:page]}" if options[:page]
                  Severity: Minor
                  Found in lib/fog/vcloud_director/requests/compute/get_users_from_query.rb - About 1 hr to fix

                    Method get_groups_from_query has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                            def get_groups_from_query(options={})
                              query = []
                              query << "sortAsc=#{options[:sortAsc]}" if options[:sortAsc]
                              query << "sortDesc=#{options[:sortDesc]}" if options[:sortDesc]
                              query << "page=#{options[:page]}" if options[:page]
                    Severity: Minor
                    Found in lib/fog/vcloud_director/requests/compute/get_groups_from_query.rb - About 1 hr to fix

                      Method get_vapp_templates_from_query has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                              def get_vapp_templates_from_query(options={})
                                query = []
                                query << "sortAsc=#{options[:sortAsc]}" if options[:sortAsc]
                                query << "sortDesc=#{options[:sortDesc]}" if options[:sortDesc]
                                query << "page=#{options[:page]}" if options[:page]

                        Method get_medias_from_query has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                                def get_medias_from_query(options={})
                                  query = []
                                  query << "sortAsc=#{options[:sortAsc]}" if options[:sortAsc]
                                  query << "sortDesc=#{options[:sortDesc]}" if options[:sortDesc]
                                  query << "page=#{options[:page]}" if options[:page]
                        Severity: Minor
                        Found in lib/fog/vcloud_director/requests/compute/get_medias_from_query.rb - About 1 hr to fix

                          Method get_vapps_in_lease_from_query has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                                  def get_vapps_in_lease_from_query(options={})
                                    query = []
                                    query << "sortAsc=#{options[:sortAsc]}" if options[:sortAsc]
                                    query << "sortDesc=#{options[:sortDesc]}" if options[:sortDesc]
                                    query << "page=#{options[:page]}" if options[:page]

                            Method get_vms_in_lease_from_query has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                    def get_vms_in_lease_from_query(options={})
                                      query = []
                                      query << "sortAsc=#{options[:sortAsc]}" if options[:sortAsc]
                                      query << "sortDesc=#{options[:sortDesc]}" if options[:sortDesc]
                                      query << "page=#{options[:page]}" if options[:page]

                              Method post_upload_disk has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                      def post_upload_disk(id, name, size, options={})
                                        body = Nokogiri::XML::Builder.new do
                                          DiskCreateParams(:xmlns => 'http://www.vmware.com/vcloud/v1.5') {
                                            attrs = {
                                              :name => name,
                              Severity: Minor
                              Found in lib/fog/vcloud_director/requests/compute/post_upload_disk.rb - About 1 hr to fix

                                Method get_vdcs_from_query has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                        def get_vdcs_from_query(options={})
                                          query = []
                                          query << "sortAsc=#{options[:sortAsc]}" if options[:sortAsc]
                                          query << "sortDesc=#{options[:sortDesc]}" if options[:sortDesc]
                                          query << "page=#{options[:page]}" if options[:page]
                                Severity: Minor
                                Found in lib/fog/vcloud_director/requests/compute/get_vdcs_from_query.rb - About 1 hr to fix

                                  Method save has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                                  Open

                                          def save
                                            if self.identity
                                              options = {
                                                :serverid => self.identity,
                                                :disksize => disksize,
                                  Severity: Minor
                                  Found in lib/fog/glesys/models/compute/server.rb - About 1 hr to fix

                                    Method post_power_on_vapp has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                                    Open

                                            def post_power_on_vapp(id)
                                              unless vapp = data[:vapps][id]
                                                raise Fog::Compute::VcloudDirector::Forbidden.new(
                                                  'This operation is denied.'
                                                )
                                    Severity: Minor
                                    Found in lib/fog/vcloud_director/requests/compute/post_power_on_vapp.rb - About 1 hr to fix

                                      Method get_vdc_storage_class has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                                      Open

                                              def get_vdc_storage_class(id)
                                                unless vdc_storage_class = data[:vdc_storage_classes][id]
                                                  raise Fog::Compute::VcloudDirector::Forbidden.new(
                                                    "No access to entity \"(com.vmware.vcloud.entity.vdcstorageProfile:#{id})\"."
                                                  )
                                      Severity: Minor
                                      Found in lib/fog/vcloud_director/requests/compute/get_vdc_storage_class.rb - About 1 hr to fix
                                        Severity
                                        Category
                                        Status
                                        Source
                                        Language