Sign upLogin

fog/fog

View on GitHub
Star
lib/fog/ibm/requests/compute/list_addresses.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method list_addresses has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

        def list_addresses
          # Loop through addresses and update states and values if they aren't set
          self.data[:addresses].values.each do |address|
            address['state']    = 2 if address['state'] == 0
            address['ip']       = Fog::IBM::Mock.ip_address if address['ip'].empty?
Severity: Minor
Found in lib/fog/ibm/requests/compute/list_addresses.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status