lib/fog/vcloud_director/generators/compute/edge_gateway_service_configuration.rb

Summary

Maintainability
D
2 days
Test Coverage

Method build_firewall_service has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
Open

          def build_firewall_service(xml)
            firewall_config = @configuration[:FirewallService]
            return unless firewall_config

            xml.FirewallService {

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method build_nat_service has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

          def build_nat_service(xml)
            nat_config = @configuration[:NatService]
            return unless nat_config

            xml.NatService {

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method build_load_balancer_service has 66 lines of code (exceeds 25 allowed). Consider refactoring.
Open

          def build_load_balancer_service(xml)
            lb_config = @configuration[:LoadBalancerService]
            return unless lb_config

            xml.LoadBalancerService {

    Method build_load_balancer_service has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

              def build_load_balancer_service(xml)
                lb_config = @configuration[:LoadBalancerService]
                return unless lb_config
    
                xml.LoadBalancerService {

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method build_vpn has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

              def build_vpn(xml)
                vpn_config = @configuration[:GatewayIpsecVpnService]
                return unless vpn_config
    
                xml.GatewayIpsecVpnService {

      Method build_firewall_service has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                def build_firewall_service(xml)
                  firewall_config = @configuration[:FirewallService]
                  return unless firewall_config
      
                  xml.FirewallService {

        Method build_vpn has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

                  def build_vpn(xml)
                    vpn_config = @configuration[:GatewayIpsecVpnService]
                    return unless vpn_config
        
                    xml.GatewayIpsecVpnService {

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                          xml.IsEnabled pool[:IsEnabled]
                          xml.Network pool[:Network]
                          xml.DefaultLeaseTime pool[:DefaultLeaseTime]
                          xml.MaxLeaseTime pool[:MaxLeaseTime]
                          xml.LowIpAddress pool[:LowIpAddress]
        lib/fog/vcloud/requests/compute/configure_network.rb on lines 30..35

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 31.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                          tunnel_config[:LocalSubnet].each do |subnet|
                            xml.LocalSubnet {
                              xml.Name subnet[:Name]
                              xml.Gateway subnet[:Gateway]
                              xml.Netmask subnet[:Netmask]
        lib/fog/vcloud_director/generators/compute/edge_gateway_service_configuration.rb on lines 69..73
        lib/fog/vcloud_director/generators/compute/edge_gateway_service_configuration.rb on lines 117..121

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                          tunnel_config[:PeerSubnet].each do |subnet|
                            xml.PeerSubnet {
                              xml.Name subnet[:Name]
                              xml.Gateway subnet[:Gateway]
                              xml.Netmask subnet[:Netmask]
        lib/fog/vcloud_director/generators/compute/edge_gateway_service_configuration.rb on lines 62..66
        lib/fog/vcloud_director/generators/compute/edge_gateway_service_configuration.rb on lines 117..121

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                              member[:ServicePort].each do |member_service_port|
                                xml.ServicePort {
                                  xml.Protocol member_service_port[:Protocol]
                                  xml.Port member_service_port[:Port]
                                  xml.HealthCheckPort member_service_port[:HealthCheckPort]
        lib/fog/vcloud_director/generators/compute/edge_gateway_service_configuration.rb on lines 62..66
        lib/fog/vcloud_director/generators/compute/edge_gateway_service_configuration.rb on lines 69..73

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status