Sign upLogin

fog/fog

View on GitHub
Star
lib/fog/vcloud_director/requests/compute/instantiate_vapp_template.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method instantiate_vapp_template has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def instantiate_vapp_template(vapp_name, template_id, options={})
          unless data[:catalog_items].values.find {|i| i[:template_id] == template_id}
            raise Fog::Compute::VcloudDirector::Forbidden.new(
              'No such template.'
            )
Severity: Major
Found in lib/fog/vcloud_director/requests/compute/instantiate_vapp_template.rb - About 2 hrs to fix

    Method generate_instantiate_vapp_template_request has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

            def generate_instantiate_vapp_template_request(options ={})

          #overriding some params so they work with new standardised generator
          options[:InstantiationParams] =
          {
    Severity: Minor
    Found in lib/fog/vcloud_director/requests/compute/instantiate_vapp_template.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status