Sign upLogin

fog/fog

View on GitHub
Star
lib/fog/vcloud_director/requests/compute/post_update_vapp_metadata.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method post_update_vapp_metadata has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

        def post_update_vapp_metadata(id, metadata={})
          body = Nokogiri::XML::Builder.new do
            attrs = {
              :xmlns => 'http://www.vmware.com/vcloud/v1.5',
              'xmlns:xsi' => 'http://www.w3.org/2001/XMLSchema-instance'
Severity: Minor
Found in lib/fog/vcloud_director/requests/compute/post_update_vapp_metadata.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method post_update_vapp_metadata has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def post_update_vapp_metadata(id, metadata={})
          body = Nokogiri::XML::Builder.new do
            attrs = {
              :xmlns => 'http://www.vmware.com/vcloud/v1.5',
              'xmlns:xsi' => 'http://www.w3.org/2001/XMLSchema-instance'
Severity: Minor
Found in lib/fog/vcloud_director/requests/compute/post_update_vapp_metadata.rb - About 1 hr to fix

    Method post_update_vapp_metadata has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def post_update_vapp_metadata(id, metadata={})
          unless vm = data[:vms][id]
            raise Fog::Compute::VcloudDirector::Forbidden.new(
              'This operation is denied.'
            )
    Severity: Minor
    Found in lib/fog/vcloud_director/requests/compute/post_update_vapp_metadata.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status