Sign upLogin

fog/fog

View on GitHub
Star
lib/fog/vcloud_director/requests/compute/post_upload_media.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method post_upload_media has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def post_upload_media(vdc_id, name, image_type, size, options={})
          unless ['iso','floppy'].include?(image_type)
            raise Fog::Compute::VcloudDirector::BadRequest.new(
              'The value of parameter imageType is incorrect.'
            )
Severity: Major
Found in lib/fog/vcloud_director/requests/compute/post_upload_media.rb - About 2 hrs to fix

    Method post_upload_media has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            def post_upload_media(vdc_id, name, image_type, size, options={})
    Severity: Minor
    Found in lib/fog/vcloud_director/requests/compute/post_upload_media.rb - About 35 mins to fix

      Method post_upload_media has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              def post_upload_media(vdc_id, name, image_type, size, options={})
      Severity: Minor
      Found in lib/fog/vcloud_director/requests/compute/post_upload_media.rb - About 35 mins to fix

        Method post_upload_media has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

                def post_upload_media(vdc_id, name, image_type, size, options={})
          unless ['iso','floppy'].include?(image_type)
            raise Fog::Compute::VcloudDirector::BadRequest.new(
              'The value of parameter imageType is incorrect.'
            )
        Severity: Minor
        Found in lib/fog/vcloud_director/requests/compute/post_upload_media.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status