Sign upLogin

foodcoops/foodsoft

View on GitHub
Star

Showing 134 of 182 total issues

Method load_data has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
Open

  def load_data
    data = {}
    data[:account_balance] = ordergroup.nil? ? BigDecimal('+Infinity') : ordergroup.account_balance
    data[:available_funds] = ordergroup.nil? ? BigDecimal('+Infinity') : ordergroup.get_available_funds(self)
Severity: Minor
Found in app/models/group_order.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class Order has 37 methods (exceeds 20 allowed). Consider refactoring.
Open

class Order < ApplicationRecord
  attr_accessor :ignore_warnings, :transport_distribution

  # Associations
  has_many :order_articles, dependent: :destroy
Severity: Minor
Found in app/models/order.rb - About 4 hrs to fix

    Method date_time_attribute has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
    Open

        def date_time_attribute(*attributes)
      super

      attributes.each do |attribute|
        validate -> { send("#{attribute}_datetime_value_valid") }
    Severity: Minor
    Found in app/lib/date_time_attribute_validate.rb - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method update_quantities has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

      def update_quantities(quantity, tolerance)
    logger.debug("GroupOrderArticle[#{id}].update_quantities(#{quantity}, #{tolerance})")
    logger.debug("Current quantity = #{self.quantity}, tolerance = #{self.tolerance}")

    # When quantity and tolerance are zero, we don't serve any purpose
    Severity: Minor
    Found in app/models/group_order_article.rb - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method calculate_result has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

      def calculate_result(total = nil)
    # return memoized result unless a total is given
    return @calculate_result if total.nil? && !@calculate_result.nil?

    quantity = tolerance = total_quantity = 0
    Severity: Minor
    Found in app/models/group_order_article.rb - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function stupidtable has 91 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      $.fn.stupidtable = function(sortFns) {
    return this.each(function() {
      var $table = $(this);
      sortFns = sortFns || {};
    Severity: Major
    Found in app/assets/javascripts/stupidtable.js - About 3 hrs to fix

      Class User has 29 methods (exceeds 20 allowed). Consider refactoring.
      Open

      class User < ApplicationRecord
  include CustomFields
  # TODO: acts_as_paraniod ??

  has_many :memberships, dependent: :destroy
      Severity: Minor
      Found in app/models/user.rb - About 3 hrs to fix

        Method add_uservoice_script has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
        Open

                def add_uservoice_script
          return unless FoodsoftUservoice.enabled?

          # include uservoice javascript
          api_key = FoodsoftConfig[:uservoice]['api_key']
        Severity: Minor
        Found in plugins/uservoice/lib/foodsoft_uservoice.rb - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method body has 80 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def body
    order_articles_data = [[
      OrderArticle.human_attribute_name(:article),
      Article.human_attribute_name(:supplier),
      ArticlePrice.human_attribute_name(:unit_quantity),
        Severity: Major
        Found in app/documents/order_matrix.rb - About 3 hrs to fix

          File order.rb has 296 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          class Order < ApplicationRecord
  attr_accessor :ignore_warnings, :transport_distribution

  # Associations
  has_many :order_articles, dependent: :destroy
          Severity: Minor
          Found in app/models/order.rb - About 3 hrs to fix

            Method update_order_amounts has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
            Open

              def update_order_amounts
    return unless params[:order_articles]

    # where to leave remainder during redistribution
    rest_to = []
            Severity: Minor
            Found in app/controllers/orders_controller.rb - About 3 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method body has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
            Open

              def body
    each_ordergroup do |oa_name, oa_total, oa_id, oa_transport|
      has_transport = !oa_transport.nil? && oa_transport > 0
      dimrows = []
      rows = [[
            Severity: Minor
            Found in app/documents/order_by_groups.rb - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method create_collection has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
            Open

              def create_collection
    raise I18n.t('finance.financial_transactions.controller.create_collection.error_note_required') if params[:note].blank?

    type = FinancialTransactionType.find_by_id(params[:type_id])
    financial_link = nil
            Severity: Minor
            Found in app/controllers/finance/financial_transactions_controller.rb - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method body has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
            Open

              def body
    # Start rendering
    each_ordergroup do |ordergroup|
      down_or_page 15
            Severity: Minor
            Found in plugins/current_orders/app/documents/multiple_orders_by_groups.rb - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method body has 65 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def body
    contact = FoodsoftConfig[:contact].symbolize_keys

    # From paragraph
    bounding_box [margin_box.right - 200, margin_box.top], width: 200 do
            Severity: Major
            Found in app/documents/order_fax.rb - About 2 hrs to fix

              Method body has 62 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                def body
    # Start rendering
    each_ordergroup do |ordergroup|
      down_or_page 15
              Severity: Major
              Found in plugins/current_orders/app/documents/multiple_orders_by_groups.rb - About 2 hrs to fix

                Method config_input has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
                Open

                  def config_input(form, key, options = {}, &block)
    return unless @cfg.allowed_key? key

    options[:label] ||= config_input_label(form, key)
    options[:required] ||= false
                Severity: Minor
                Found in app/helpers/admin/configs_helper.rb - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method sync_from_file has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
                Open

                  def sync_from_file(file, options = {})
    all_order_numbers = []
    updated_article_pairs = []
    outlisted_articles = []
    new_articles = []
                Severity: Minor
                Found in app/models/supplier.rb - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Class OrderArticle has 22 methods (exceeds 20 allowed). Consider refactoring.
                Open

                class OrderArticle < ApplicationRecord
  include FindEachWithOrder

  attr_reader :update_global_price
                Severity: Minor
                Found in app/models/order_article.rb - About 2 hrs to fix

                  Method date_time_attribute has 58 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      def date_time_attribute(*attributes)
      super

      attributes.each do |attribute|
        validate -> { send("#{attribute}_datetime_value_valid") }
                  Severity: Major
                  Found in app/lib/date_time_attribute_validate.rb - About 2 hrs to fix
                    Severity
                    Category
                    Status
                    Source
                    Language