Sign upLogin

forefrontlabs/kempelen

View on GitHub
Star

Showing 11 of 11 total issues

Method create_request_string has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

        def create_request_string
          create_parameters

          request_str = ""
Severity: Minor
Found in lib/kempelen/API/operations/base.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create_parameters has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

        def create_parameters
          @parameters[:operation] = AWS_OPERATION_NAME

          if @hit_type_id.nil?
            @parameters[:assignment_duration] = @assignment_duration
Severity: Minor
Found in lib/kempelen/API/operations/create_hit.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method load_from_response has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

        def load_from_response(response)
          super(response)

          return if response.nil?
Severity: Minor
Found in lib/kempelen/API/responses/reviewable_hits_response.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create_request_string has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def create_request_string
          create_parameters

          request_str = ""
Severity: Minor
Found in lib/kempelen/API/operations/base.rb - About 1 hr to fix

    Method load_from_answer has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

            def load_from_answer(answer)
          parser = Nori.new(:parser => :rexml)
          parsed_data = parser.parse(answer)
          answer_list = parsed_data["QuestionFormAnswers"]["Answer"]
    Severity: Minor
    Found in lib/kempelen/API/common/question_form_answers.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method load_from_response has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

            def load_from_response(response)
          @request_id = response["OperationRequest"]["RequestId"] rescue nil

          unless response.nil?
            response.each_key do |k|
    Severity: Minor
    Found in lib/kempelen/API/responses/base.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method parse_from_response has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

            def parse_from_response(response)
          error = response["Error"]
          unless error.nil?
            @code = error["Code"]
            @message = error["Message"]
    Severity: Minor
    Found in lib/kempelen/API/responses/error_response.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            def initialize(client, title, description, reward, assignment_duration, &block)
    Severity: Minor
    Found in lib/kempelen/API/operations/register_hit_type.rb - About 45 mins to fix

      Method load_from_response has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

              def load_from_response(response)
          super(response)

          hit_response = response["HIT"]
          unless hit_response.nil?
      Severity: Minor
      Found in lib/kempelen/API/responses/hit_response.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        module API
    module Operations
      class GetHit < HitOperation
        AWS_OPERATION_NAME = "GetHIT".freeze
        AWS_RESPONSE_OBJECT = "GetHITResponse".freeze
      Severity: Minor
      Found in lib/kempelen/API/operations/get_hit.rb and 1 other location - About 25 mins to fix
      lib/kempelen/API/operations/force_expire_hit.rb on lines 2..20

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 29.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        module API
    module Operations
      class ForceExpireHit < HitOperation
        AWS_OPERATION_NAME = "ForceExpireHIT".freeze
        AWS_RESPONSE_OBJECT = "ForceExpireHITResponse".freeze
      Severity: Minor
      Found in lib/kempelen/API/operations/force_expire_hit.rb and 1 other location - About 25 mins to fix
      lib/kempelen/API/operations/get_hit.rb on lines 2..20

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 29.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language