forefrontlabs/kempelen

View on GitHub

Showing 9 of 11 total issues

Method create_request_string has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

        def create_request_string
          create_parameters

          request_str = ""

Severity: Minor
Found in lib/kempelen/API/operations/base.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create_parameters has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

        def create_parameters
          @parameters[:operation] = AWS_OPERATION_NAME

          if @hit_type_id.nil?
            @parameters[:assignment_duration] = @assignment_duration
Severity: Minor
Found in lib/kempelen/API/operations/create_hit.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method load_from_response has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

        def load_from_response(response)
          super(response)

          return if response.nil?

Severity: Minor
Found in lib/kempelen/API/responses/reviewable_hits_response.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create_request_string has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def create_request_string
          create_parameters

          request_str = ""

Severity: Minor
Found in lib/kempelen/API/operations/base.rb - About 1 hr to fix

    Method load_from_answer has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

            def load_from_answer(answer)
              parser = Nori.new(:parser => :rexml)
              parsed_data = parser.parse(answer)
              answer_list = parsed_data["QuestionFormAnswers"]["Answer"]
    
    
    Severity: Minor
    Found in lib/kempelen/API/common/question_form_answers.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method load_from_response has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

            def load_from_response(response)
              @request_id = response["OperationRequest"]["RequestId"] rescue nil
    
              unless response.nil?
                response.each_key do |k|
    Severity: Minor
    Found in lib/kempelen/API/responses/base.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method parse_from_response has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

            def parse_from_response(response)
              error = response["Error"]
              unless error.nil?
                @code = error["Code"]
                @message = error["Message"]
    Severity: Minor
    Found in lib/kempelen/API/responses/error_response.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            def initialize(client, title, description, reward, assignment_duration, &block)
    Severity: Minor
    Found in lib/kempelen/API/operations/register_hit_type.rb - About 45 mins to fix

      Method load_from_response has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

              def load_from_response(response)
                super(response)
      
                hit_response = response["HIT"]
                unless hit_response.nil?
      Severity: Minor
      Found in lib/kempelen/API/responses/hit_response.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language