Sign upLogin

formtastic/formtastic

View on GitHub
Star
lib/formtastic/localizer.rb

Summary

Maintainability
C
1 day
Test Coverage

Method localize has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

    def localize(key, value, type, options = {}) # @private
      key = value if value.is_a?(::Symbol)

      if value.is_a?(::String)
        escape_html_entities(value)
Severity: Minor
Found in lib/formtastic/localizer.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method localize has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def localize(key, value, type, options = {}) # @private
      key = value if value.is_a?(::Symbol)

      if value.is_a?(::String)
        escape_html_entities(value)
Severity: Minor
Found in lib/formtastic/localizer.rb - About 1 hr to fix

    Method escape_html_entities has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def escape_html_entities(string) # @private
      if (builder.escape_html_entities_in_hints_and_labels) ||
         (self.respond_to?(:escape_html_entities_in_hints_and_labels) && escape_html_entities_in_hints_and_labels)
        string = builder.template.escape_once(string) unless string.respond_to?(:html_safe?) && string.html_safe? == true # Accept html_safe flag as indicator to skip escaping
      end
    Severity: Minor
    Found in lib/formtastic/localizer.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status