fossasia/AYABInterface

View on GitHub
AYABInterface/communication/test/test_state_machine.py

Summary

Maintainability
B
4 hrs
Test Coverage

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    def test_success(self, state, message, communication):
        message.is_success.return_value = True
        state.receive_start_confirmation(message)
        assert communication.state.is_knitting_started()
Severity: Major
Found in AYABInterface/communication/test/test_state_machine.py and 4 other locations - About 50 mins to fix
AYABInterface/communication/test/test_state_machine.py on lines 87..90
AYABInterface/communication/test/test_state_machine.py on lines 92..95
AYABInterface/communication/test/test_state_machine.py on lines 112..115
AYABInterface/communication/test/test_state_machine.py on lines 133..136

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    def test_failure(self, state, message, communication):
        message.is_success.return_value = False
        state.receive_start_confirmation(message)
        assert communication.state.is_starting_failed()
Severity: Major
Found in AYABInterface/communication/test/test_state_machine.py and 4 other locations - About 50 mins to fix
AYABInterface/communication/test/test_state_machine.py on lines 87..90
AYABInterface/communication/test/test_state_machine.py on lines 92..95
AYABInterface/communication/test/test_state_machine.py on lines 112..115
AYABInterface/communication/test/test_state_machine.py on lines 128..131

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    def test_positive_response(self, state, message, communication):
        message.api_version_is_supported.return_value = True
        state.receive_information_confirmation(message)
        assert communication.state.is_initializing_machine()
Severity: Major
Found in AYABInterface/communication/test/test_state_machine.py and 4 other locations - About 50 mins to fix
AYABInterface/communication/test/test_state_machine.py on lines 92..95
AYABInterface/communication/test/test_state_machine.py on lines 112..115
AYABInterface/communication/test/test_state_machine.py on lines 128..131
AYABInterface/communication/test/test_state_machine.py on lines 133..136

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    def test_ready_indicated(self, state, message, communication):
        message.is_ready_to_knit.return_value = True
        state.receive_state_indication(message)
        assert communication.state.is_starting_to_knit()
Severity: Major
Found in AYABInterface/communication/test/test_state_machine.py and 4 other locations - About 50 mins to fix
AYABInterface/communication/test/test_state_machine.py on lines 87..90
AYABInterface/communication/test/test_state_machine.py on lines 92..95
AYABInterface/communication/test/test_state_machine.py on lines 128..131
AYABInterface/communication/test/test_state_machine.py on lines 133..136

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    def test_negative_response(self, state, message, communication):
        message.api_version_is_supported.return_value = False
        state.receive_information_confirmation(message)
        assert communication.state.is_unsupported_api_version()
Severity: Major
Found in AYABInterface/communication/test/test_state_machine.py and 4 other locations - About 50 mins to fix
AYABInterface/communication/test/test_state_machine.py on lines 87..90
AYABInterface/communication/test/test_state_machine.py on lines 112..115
AYABInterface/communication/test/test_state_machine.py on lines 128..131
AYABInterface/communication/test/test_state_machine.py on lines 133..136

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status