fossasia/kniteditor

View on GitHub

Identical code found in 1 other location (mass = 73)
Open

if len(sys.argv) == 1:
    try:
        main()
    except:
        import traceback
windows-build/KnitEditor.py on lines 8..22

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical code found in 1 other location (mass = 73)
Open

if len(sys.argv) == 1:
    try:
        main()
    except:
        import traceback
mac-build/_KnitEditor.py on lines 7..21

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar code found in 1 other location (mass = 58)
Open

    def show_open_file_dialog(self):
        """Open the file dialog for loading."""
        content = LoadDialog(load=self.load_path, cancel=self.dismiss_popup)
        self._popup = Popup(title="Load file", content=content,
                            size_hint=(0.9, 0.9))
kniteditor/EditorWindow.py on lines 32..37

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 58.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar code found in 1 other location (mass = 58)
Open

    def show_save_file_dialog(self):
        """Open the file dialog for saving."""
        content = SaveDialog(save=self.save_path, cancel=self.dismiss_popup)
        self._popup = Popup(title="Save file", content=content,
                            size_hint=(0.9, 0.9))
kniteditor/EditorWindow.py on lines 25..30

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 58.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar code found in 1 other location (mass = 35)
Open

    if not isinstance(language_code, str):
        message = "Invalid argument {}. Expected str instance.".format(
            repr(language_code))
        raise TypeError(message)
kniteditor/localization/__init__.py on lines 113..116

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar code found in 1 other location (mass = 35)
Open

    if not isinstance(translated_language_code, str):
        message = "Invalid argument {}. Expected str instance.".format(
            repr(translated_language_code))
        raise TypeError(message)
kniteditor/localization/__init__.py on lines 93..96

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Cyclomatic complexity is too high in method run. (7)
Open

    def run(self):
        assert self.site_packages, "We need a folder to install to."
        print("link: {} -> {}".format(
                  os.path.join(self.site_packages[0], PACKAGE_NAME),
                  self.library_path
Severity: Minor
Found in setup.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

| Construct | Effect on CC | Reasoning | | --------- | ------------ | --------- | | if | +1 | An if statement is a single decision. | | elif| +1| The elif statement adds another decision. | | else| +0| The else statement does not cause a new decision. The decision is at the if. | | for| +1| There is a decision at the start of the loop. | | while| +1| There is a decision at the while statement. | | except| +1| Each except branch adds a new conditional path of execution. | | finally| +0| The finally block is unconditionally executed. | | with| +1| The with statement roughly corresponds to a try/except block (see PEP 343 for details). | | assert| +1| The assert statement internally roughly equals a conditional statement. | | Comprehension| +1| A list/set/dict comprehension of generator expression is equivalent to a for loop. | | Boolean Operator| +1| Every boolean operator (and, or) adds a decision point. |

Source: http://radon.readthedocs.org/en/latest/intro.html

Cyclomatic complexity is too high in function module_name_and_doc. (6)
Open

def module_name_and_doc(relative_path):
    assert relative_path.startswith(PACKAGE)
    file, ext = os.path.splitext(relative_path)
    assert ext == ".py"
    names = []

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

| Construct | Effect on CC | Reasoning | | --------- | ------------ | --------- | | if | +1 | An if statement is a single decision. | | elif| +1| The elif statement adds another decision. | | else| +0| The else statement does not cause a new decision. The decision is at the if. | | for| +1| There is a decision at the start of the loop. | | while| +1| There is a decision at the while statement. | | except| +1| Each except branch adds a new conditional path of execution. | | finally| +0| The finally block is unconditionally executed. | | with| +1| The with statement roughly corresponds to a try/except block (see PEP 343 for details). | | assert| +1| The assert statement internally roughly equals a conditional statement. | | Comprehension| +1| A list/set/dict comprehension of generator expression is equivalent to a for loop. | | Boolean Operator| +1| Every boolean operator (and, or) adds a decision point. |

Source: http://radon.readthedocs.org/en/latest/intro.html

Cyclomatic complexity is too high in method run. (6)
Open

    def run(self):
        for package in self.packages_to_clean:
            try:
                __init__ = __import__(package).__file__
            except ImportError:
Severity: Minor
Found in setup.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

| Construct | Effect on CC | Reasoning | | --------- | ------------ | --------- | | if | +1 | An if statement is a single decision. | | elif| +1| The elif statement adds another decision. | | else| +0| The else statement does not cause a new decision. The decision is at the if. | | for| +1| There is a decision at the start of the loop. | | while| +1| There is a decision at the while statement. | | except| +1| Each except branch adds a new conditional path of execution. | | finally| +0| The finally block is unconditionally executed. | | with| +1| The with statement roughly corresponds to a try/except block (see PEP 343 for details). | | assert| +1| The assert statement internally roughly equals a conditional statement. | | Comprehension| +1| A list/set/dict comprehension of generator expression is equivalent to a for loop. | | Boolean Operator| +1| Every boolean operator (and, or) adds a decision point. |

Source: http://radon.readthedocs.org/en/latest/intro.html

TODO found
Open

# TODO
Severity: Minor
Found in docs/conf.py by fixme

TODO found
Open

# TODO
Severity: Minor
Found in docs/conf.py by fixme

TODO found
Open

     author, project, 'One line description of project.',  # TODO
Severity: Minor
Found in docs/conf.py by fixme

FIXME found
Open

notes=FIXME,XXX,TODO
Severity: Minor
Found in pylintrc by fixme

XXX found
Open

notes=FIXME,XXX,TODO
Severity: Minor
Found in pylintrc by fixme

TODO found
Open

notes=FIXME,XXX,TODO
Severity: Minor
Found in pylintrc by fixme
Severity
Category
Status