Sign upLogin

fredjean/simpler_workflow

View on GitHub
Star

Showing 6 of 6 total issues

Method start_activity_loop has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    def start_activity_loop
      SimplerWorkflow.child_processes << fork do

        $0 = "Activity: #{name} #{version}"
Severity: Minor
Found in lib/simpler_workflow/activity.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method decision_loop has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    def decision_loop
      SimplerWorkflow.child_processes << fork do

        $0 = "Workflow: #{name} #{version}"
Severity: Minor
Found in lib/simpler_workflow/workflow.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class Activity has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Activity
    include OptionsAsMethods

    attr_reader :domain, :name, :version, :options, :next_activity, :task_list
Severity: Minor
Found in lib/simpler_workflow/activity.rb - About 2 hrs to fix

    Method start_activity_loop has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def start_activity_loop
      SimplerWorkflow.child_processes << fork do

        $0 = "Activity: #{name} #{version}"
    Severity: Minor
    Found in lib/simpler_workflow/activity.rb - About 1 hr to fix

      Method decision_loop has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def decision_loop
      SimplerWorkflow.child_processes << fork do

        $0 = "Workflow: #{name} #{version}"
      Severity: Minor
      Found in lib/simpler_workflow/workflow.rb - About 1 hr to fix

        Method register_workflow has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def register_workflow(name, version, &block)
      unless workflow = Workflow[name, version]
        workflow = Workflow.new(self, name, version)

        workflow.instance_eval(&block) if block_given?
        Severity: Minor
        Found in lib/simpler_workflow/domain.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language