Sign upLogin

garak/bridge

View on GitHub
Star

Showing 5 of 5 total issues

Game has 37 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class Game
{
    protected ?Player $playerN = null;

    protected ?Player $playerE = null;
Severity: Minor
Found in src/Game.php - About 4 hrs to fix

    File Game.php has 303 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace Garak\Bridge;

use Doctrine\Common\Collections\ArrayCollection;
    Severity: Minor
    Found in src/Game.php - About 3 hrs to fix

      Function getWinningCard has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getWinningCard(?Suit $trump): Card
    {
        if (false === $firstCard = \reset($this->cards)) {
            throw new \DomainException('No cards in trick.');
        }
      Severity: Minor
      Found in src/Trick.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                  return $card1->getSuit()->getInt() <=> $card2->getSuit()->getInt();
      Severity: Major
      Found in src/CardSorter.php - About 30 mins to fix

        Function isGreaterThanPrevious has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            private function isGreaterThanPrevious(Auction $auction): bool
    {
        if ($this->auctions->count() < 1 || null === $auction->getValue()) {
            return true;    // first auction, or pass
        }
        Severity: Minor
        Found in src/Game.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language