garak/bridge

View on GitHub
src/Game.php

Summary

Maintainability
C
1 day
Test Coverage
A
92%

Game has 37 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class Game
{
    protected ?Player $playerN = null;

    protected ?Player $playerE = null;
Severity: Minor
Found in src/Game.php - About 4 hrs to fix

    File Game.php has 303 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    namespace Garak\Bridge;
    
    use Doctrine\Common\Collections\ArrayCollection;
    Severity: Minor
    Found in src/Game.php - About 3 hrs to fix

      Function isGreaterThanPrevious has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          private function isGreaterThanPrevious(Auction $auction): bool
          {
              if ($this->auctions->count() < 1 || null === $auction->getValue()) {
                  return true;    // first auction, or pass
              }
      Severity: Minor
      Found in src/Game.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status