gdbots/query-parser-php

View on GitHub
src/Builder/AbstractQueryBuilder.php

Summary

Maintainability
D
1 day
Test Coverage

AbstractQueryBuilder has 42 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class AbstractQueryBuilder implements QueryBuilder
{
    private ?Field $currentField = null;
    private bool $queryOnFieldIsCacheable = false;
    private bool $inField = false;
Severity: Minor
Found in src/Builder/AbstractQueryBuilder.php - About 5 hrs to fix

    File AbstractQueryBuilder.php has 371 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    declare(strict_types=1);
    
    namespace Gdbots\QueryParser\Builder;
    
    
    Severity: Minor
    Found in src/Builder/AbstractQueryBuilder.php - About 4 hrs to fix

      Consider simplifying this complex logical expression.
      Open

              if ($node->useFuzzy()
                  || $this->supportsFullTextSearch($field->getName())
                  || $node instanceof Subquery
                  || $node instanceof WordRange
                  || $node instanceof Phrase
      Severity: Major
      Found in src/Builder/AbstractQueryBuilder.php - About 1 hr to fix

        Function handleText has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            private function handleText(Node $node): void
            {
                if ($this->inField && !$this->supportsFullTextSearch($this->currentField->getName())) {
                    $this->handleTerm($node);
                    return;
        Severity: Minor
        Found in src/Builder/AbstractQueryBuilder.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            final public function addHashtag(Hashtag $hashtag): self
            {
                if ($this->inField || null === $this->hashtagFieldName) {
                    $this->handleTerm($hashtag);
                    return $this;
        Severity: Major
        Found in src/Builder/AbstractQueryBuilder.php and 3 other locations - About 35 mins to fix
        src/Builder/AbstractQueryBuilder.php on lines 187..203
        src/Builder/AbstractQueryBuilder.php on lines 205..221
        src/Builder/AbstractQueryBuilder.php on lines 259..275

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 92.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            final public function addMention(Mention $mention): self
            {
                if ($this->inField || null === $this->mentionFieldName) {
                    $this->handleTerm($mention);
                    return $this;
        Severity: Major
        Found in src/Builder/AbstractQueryBuilder.php and 3 other locations - About 35 mins to fix
        src/Builder/AbstractQueryBuilder.php on lines 187..203
        src/Builder/AbstractQueryBuilder.php on lines 205..221
        src/Builder/AbstractQueryBuilder.php on lines 241..257

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 92.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            final public function addEmoticon(Emoticon $emoticon): self
            {
                if ($this->inField || null === $this->emoticonFieldName) {
                    $this->handleTerm($emoticon);
                    return $this;
        Severity: Major
        Found in src/Builder/AbstractQueryBuilder.php and 3 other locations - About 35 mins to fix
        src/Builder/AbstractQueryBuilder.php on lines 187..203
        src/Builder/AbstractQueryBuilder.php on lines 241..257
        src/Builder/AbstractQueryBuilder.php on lines 259..275

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 92.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            final public function addEmoji(Emoji $emoji): self
            {
                if ($this->inField || null === $this->emojiFieldName) {
                    $this->handleTerm($emoji);
                    return $this;
        Severity: Major
        Found in src/Builder/AbstractQueryBuilder.php and 3 other locations - About 35 mins to fix
        src/Builder/AbstractQueryBuilder.php on lines 205..221
        src/Builder/AbstractQueryBuilder.php on lines 241..257
        src/Builder/AbstractQueryBuilder.php on lines 259..275

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 92.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status