gdbots/query-parser-php

View on GitHub
src/Node/Date.php

Summary

Maintainability
A
50 mins
Test Coverage

Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

        string $value,
        ?BoolOperator $boolOperator = null,
        bool $useBoost = false,
        float $boost = self::DEFAULT_BOOST,
        bool $useFuzzy = false,
Severity: Major
Found in src/Node/Date.php - About 50 mins to fix

    The method fromArray() has an NPath complexity of 288. The configured NPath complexity threshold is 200.
    Open

        public static function fromArray(array $data = [])
        {
            $value = isset($data['value']) ? $data['value'] : '';
            $useBoost = isset($data['use_boost']) ? (bool)$data['use_boost'] : false;
            $boost = isset($data['boost']) ? (float)$data['boost'] : self::DEFAULT_BOOST;
    Severity: Minor
    Found in src/Node/Date.php by phpmd

    Since: PHPMD 0.1

    The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

    Example:

    class Foo {
          function bar() {
              // lots of complicated code
          }
      }

    Source: http://phpmd.org/rules/codesize.txt

    The method fromArray() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
    Open

        public static function fromArray(array $data = [])
        {
            $value = isset($data['value']) ? $data['value'] : '';
            $useBoost = isset($data['use_boost']) ? (bool)$data['use_boost'] : false;
            $boost = isset($data['boost']) ? (float)$data['boost'] : self::DEFAULT_BOOST;
    Severity: Minor
    Found in src/Node/Date.php by phpmd

    Since: PHPMD 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example:

    // Cyclomatic Complexity = 11
      class Foo {
      1   public function example() {
      2       if ($a == $b) {
      3           if ($a1 == $b1) {
                      fiddle();
      4           } elseif ($a2 == $b2) {
                      fiddle();
                  } else {
                      fiddle();
                  }
      5       } elseif ($c == $d) {
      6           while ($c == $d) {
                      fiddle();
                  }
      7        } elseif ($e == $f) {
      8           for ($n = 0; $n < $h; $n++) {
                      fiddle();
                  }
              } else {
                  switch ($z) {
      9               case 1:
                          fiddle();
                          break;
      10              case 2:
                          fiddle();
                          break;
      11              case 3:
                          fiddle();
                          break;
                      default:
                          fiddle();
                          break;
                  }
              }
          }
      }

    Source: http://phpmd.org/rules/codesize.txt

    The method __construct has a boolean flag argument $useBoost, which is a certain sign of a Single Responsibility Principle violation.
    Open

            bool $useBoost = false,
    Severity: Minor
    Found in src/Node/Date.php by phpmd

    Since: PHPMD 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example:

    class Foo {
          public function bar($flag = true) {
          }
      }

    Source: http://phpmd.org/rules/cleancode.txt

    The method __construct has a boolean flag argument $useFuzzy, which is a certain sign of a Single Responsibility Principle violation.
    Open

            bool $useFuzzy = false,
    Severity: Minor
    Found in src/Node/Date.php by phpmd

    Since: PHPMD 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example:

    class Foo {
          public function bar($flag = true) {
          }
      }

    Source: http://phpmd.org/rules/cleancode.txt

    Avoid using static access to class '\Gdbots\QueryParser\Enum\BoolOperator' in method 'fromArray'.
    Open

                $boolOperator = isset($data['bool_operator']) ? BoolOperator::create($data['bool_operator']) : null;
    Severity: Minor
    Found in src/Node/Date.php by phpmd

    Since: PHPMD 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example:

    class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

    Source: http://phpmd.org/rules/cleancode.txt

    Avoid using static access to class '\Gdbots\QueryParser\Enum\ComparisonOperator' in method '__construct'.
    Open

            $this->comparisonOperator = $comparisonOperator ?: ComparisonOperator::EQ();
    Severity: Minor
    Found in src/Node/Date.php by phpmd

    Since: PHPMD 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example:

    class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

    Source: http://phpmd.org/rules/cleancode.txt

    Avoid using static access to class '\Gdbots\QueryParser\Enum\ComparisonOperator' in method 'toArray'.
    Open

            if ($this->comparisonOperator->equals(ComparisonOperator::EQ())) {
    Severity: Minor
    Found in src/Node/Date.php by phpmd

    Since: PHPMD 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example:

    class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

    Source: http://phpmd.org/rules/cleancode.txt

    Avoid using static access to class '\DateTime' in method 'toDateTime'.
    Open

            $date = \DateTime::createFromFormat('!Y-m-d', $this->getValue(), $timeZone ?: self::$utc);
    Severity: Minor
    Found in src/Node/Date.php by phpmd

    Since: PHPMD 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example:

    class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

    Source: http://phpmd.org/rules/cleancode.txt

    Avoid using static access to class '\Gdbots\QueryParser\Enum\ComparisonOperator' in method 'fromArray'.
    Open

                $comparisonOperator = isset($data['comparison_operator']) ? ComparisonOperator::create($data['comparison_operator']) : null;
    Severity: Minor
    Found in src/Node/Date.php by phpmd

    Since: PHPMD 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example:

    class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

    Source: http://phpmd.org/rules/cleancode.txt

    Avoid using static access to class '\Gdbots\QueryParser\Enum\ComparisonOperator' in method 'useComparisonOperator'.
    Open

            return !$this->comparisonOperator->equals(ComparisonOperator::EQ());
    Severity: Minor
    Found in src/Node/Date.php by phpmd

    Since: PHPMD 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example:

    class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

    Source: http://phpmd.org/rules/cleancode.txt

    Avoid using static access to class '\DateTime' in method 'toDateTime'.
    Open

                $date = \DateTime::createFromFormat('!Y-m-d', (new \DateTime())->format('Y-m-d'), $timeZone ?: self::$utc);
    Severity: Minor
    Found in src/Node/Date.php by phpmd

    Since: PHPMD 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example:

    class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

    Source: http://phpmd.org/rules/cleancode.txt

    Line exceeds 120 characters; contains 136 characters
    Open

                $comparisonOperator = isset($data['comparison_operator']) ? ComparisonOperator::create($data['comparison_operator']) : null;
    Severity: Minor
    Found in src/Node/Date.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status